feat(eslint-plugin): add new rule no-require-imports #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
==========================================
+ Coverage 96.78% 96.78% +<.01%
==========================================
Files 55 56 +1
Lines 2516 2522 +6
Branches 372 372
==========================================
+ Hits 2435 2441 +6
Misses 42 42
Partials 39 39
|
bradzacher
requested changes
Feb 3, 2019
10f3bc8 to
7ea0f4d
Compare
Adds the equivalent of TSLint's [`no-require-imports`](https://palantir.github.io/tslint/rules/no-require-imports/) rule.
7ea0f4d to
1de278f
Compare
|
@bradzacher Thank you for your review :) I've addressed all the comments. Could you please check it out? |
bradzacher
previously approved these changes
Feb 4, 2019
|
Just thinking — would this be better suited as a rule in |
|
Not sure what's best here. I can try moving this over to |
|
I think the rule should stay here. |
|
Apologies for the conflicts, we decided to remove the counts from the ROADMAP here: #225 They are too awkward to maintain manually, so this is the last time you will have to deal with syncing that up! |
armano2
approved these changes
Feb 7, 2019
bradzacher
approved these changes
Feb 7, 2019
JamesHenry
approved these changes
Feb 7, 2019
kaicataldo
pushed a commit
to kaicataldo/typescript-eslint
that referenced
this pull request
Aug 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the equivalent of TSLint's
no-require-importsrule.