Skip to content

fix(parser): fix visiting props of TSDeclareFunction #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 12, 2019
Merged

fix(parser): fix visiting props of TSDeclareFunction #244

merged 6 commits into from
Feb 12, 2019

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Feb 11, 2019

fixes: #18

@armano2 armano2 self-assigned this Feb 11, 2019
@armano2 armano2 added the bug Something isn't working label Feb 11, 2019
@armano2 armano2 mentioned this pull request Feb 11, 2019
Closed
8 tasks
@armano2 armano2 requested a review from bradzacher February 11, 2019 02:09
@codecov
Copy link

codecov bot commented Feb 11, 2019 •
edited
Loading

Codecov Report

Merging #244 into master will decrease coverage by <.01%.
The diff coverage is 96.42%.

@@            Coverage Diff            @@
##           master    #244      +/-   ##
=========================================
- Coverage    94.6%   94.6%   -0.01%     
=========================================
  Files          63      65       +2     
  Lines        2762    2778      +16     
  Branches      719     720       +1     
=========================================
+ Hits         2613    2628      +15     
  Misses         57      57              
- Partials       92      93       +1
Impacted Files Coverage Δ
packages/parser/src/scope/scope-manager.ts 100% <100%> (ø)
packages/parser/src/scope/scopes.ts 100% <100%> (ø)
packages/parser/src/analyze-scope.ts 95.47% <94.11%> (-0.3%) ⬇️

@armano2 armano2 requested review from a team and removed request for bradzacher February 11, 2019 18:44
@armano2 armano2 merged commit b40def8 into typescript-eslint:master Feb 12, 2019
@armano2 armano2 deleted the declare-function branch February 12, 2019 14:06
@armano2 armano2 mentioned this pull request Jan 28, 2020
Closed
7 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees

@armano2 armano2

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-undef: false flag on typeof argument types
2 participants
@armano2 @JamesHenry