[no-unused-vars] throws "Node must be provided when reporting error if location is not provided" on string enum #2486
Labels
fix: user error
issue was fixed by correcting the configuration / correcting the code
package: eslint-plugin
Issues related to @typescript-eslint/eslint-plugin
Comments
|
You are testing the default eslint rule, not the typescript-eslint one, if you disable the eslint rule and enable ours it works correctly. see this and documentation |
|
You ticked the box saying you have read the FAQ, but I don't think you did. As @tadhgmister pointed out, there is an extension rule to use. Please reconfigure appropriately. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Repro
I have added a failing test to my fork, you can check out the code Samox#1 and run
cd packages/eslint-plugin && yarn test ./tests/eslint-rules/no-unused-vars.test.ts.I'd be glad to fix the issue myself but have no idea how to do it.
I thought it would be easier with a failing test on your repo than a copy of package.json, tsconfig, etc.
Expected Result
String enum are properly parsed and the rule no-unused-vars does not throw "Node must be provided when reporting error if location is not provided" so we can easily find where the issue is.
Actual Result
I upgraded to typescript 4 and latest version of typescript-eslint. Eslint started throwing a "Node must be provided when reporting error if location is not provided". I had to add logs to eslint-plugin to understand where the issue was, it was an enum and I fixed the issue by removing the strings.
The text was updated successfully, but these errors were encountered: