Skip to content

[no-unused-vars] False positive with template string type argument #2495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
arimah opened this issue Sep 5, 2020 · 1 comment
Closed
3 tasks done

[no-unused-vars] False positive with template string type argument #2495

arimah opened this issue Sep 5, 2020 · 1 comment
Labels
duplicate This issue or pull request already exists package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@arimah
Copy link

arimah commented Sep 5, 2020

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have read the FAQ and my problem is not listed.

Repro

Minimal repo: arimah/typescript-eslint-no-unused-vars-issue-1

{
  "parserOptions": {
    "sourceType": "module"
  },
  "rules": {
    "@typescript-eslint/no-unused-vars": "error"
  }
}
function foo<T>(x: TemplateStringsArray, ...y: T[]) {
  // (irrelevant code to get rid of unused variable warnings)
  return [x,  y];
}

interface FalsePositive { }
//        ^^^^^^^^^^^^^ @typescript-eslint/no-unused-vars - false positive

foo<FalsePositive>``;

Expected Result

No lint error: the type is used as a template string type argument.

Actual Result

6:11  error  'FalsePositive' is defined but never used  @typescript-eslint/no-unused-vars

Additional Info

False positive only occurs with "sourceType": "module". With that option unset, I can't reproduce the bug, even if I introduce an explicit export or import into the code.

Versions

package version
@typescript-eslint/eslint-plugin 4.0.1
@typescript-eslint/parser 4.0.1
TypeScript 4.0.2
ESLint 7.8.1
node 12.16.1
@arimah arimah added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look labels Sep 5, 2020
@bradzacher bradzacher added duplicate This issue or pull request already exists and removed triage Waiting for team members to take a look labels Sep 5, 2020
@bradzacher
Copy link
Member

Duplicate of #2452

@bradzacher bradzacher marked this as a duplicate of #2452 Sep 5, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue or pull request already exists package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Development

No branches or pull requests

2 participants