-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Out of memory error in pre-commit hook #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
we should probably consider dropping the tests from the pre-commit hook. Can use pre-push to run the tests. Though we might be getting to the point that we shouldn't just run the entirety of the test suite locally (automatically). Jest has support for the following commands we could use in a hook/ci:
|
(Currently, I have removed I agree to use |
+1 to removing tests from the -1 to adding to the |
Running tests in past when projects was separated was fast and simple but now even if you are doing one line fix in plugin you have to rerun tests for all projects. We are adding more and more rules to project and its starting being slow, on my pc it's taking around one minute and it's every commit, even if I tested it before trying to commit it. Personally I removed hooks on my pc and I think that we should remove tests from hooks. |
I removed the tests also, it takes me ~3min to commit currently with tests enabled, to run the tests specific for a rule I use |
In standardising our config, we should *either* use booleans, or strings. Offering the ability to configure the rule via `true`/`false` as well as `"always"`/`"never"` makes the docs harder to understand. - [breaking] remove true/false options - cleanup tests/docs - switch to messageId
Fixes typescript-eslint#144 Requires ~~typescript-eslint#259~~, ~~typescript-eslint#260~~. - added a util to make it standardised and easier to add default config for a rule - configured recommended based on typescript-eslint#144 - purposely switched `recommended` prop to be `"error" | "warning" | false` - inside the eslint repo, it should be `true`. otherwise it's just a property that isn't used officially by eslint. It's truthy so `eslint-docs` still work. - changed recommended generator to accept `"error"`/`"warning"` for more configurability. - adjusted default config of certain rules that didn't match our recommendations.
I have encountered out of memory error in pre-commit hook and I cannot commit any change.
Can we remove the pre-commit hook?
The text was updated successfully, but these errors were encountered: