Skip to content

[type-annotation-spacing] Space between ? and : #3140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Knutas opened this issue Mar 3, 2021 · 0 comments · Fixed by #3138
Closed

[type-annotation-spacing] Space between ? and : #3140

Knutas opened this issue Mar 3, 2021 · 0 comments · Fixed by #3138
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@Knutas
Copy link
Contributor

Knutas commented Mar 3, 2021

Repro

{
  "rules": {
    "@typescript-eslint/type-annotation-spacing": ["error"]
  }
}
function foo(a ? : string) {}

Expected Result

Expected error Unexpected space before the ':'.

Actual Result

No error.

Versions

package version
@typescript-eslint/eslint-plugin 4.6.0
@typescript-eslint/parser 4.6.0
TypeScript 4.0.2
ESLint 7.12.1
node 14.8.0
@Knutas Knutas added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look labels Mar 3, 2021
@Knutas Knutas mentioned this issue Mar 3, 2021
Merged
@bradzacher bradzacher added enhancement: plugin rule option New rule option for an existing eslint-plugin rule and removed triage Waiting for team members to take a look labels Mar 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(eslint-plugin): [type-annotation-spacing] handle space between ? and : Knutas/typescript-eslint
2 participants
@Knutas @bradzacher