Skip to content

Remove "TODO - enable"s from .eslintrc.js internally #3278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Apr 11, 2021 · 0 comments · Fixed by #4651
Closed

Remove "TODO - enable"s from .eslintrc.js internally #3278

JoshuaKGoldberg opened this issue Apr 11, 2021 · 0 comments · Fixed by #4651
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Ignoring the template because it's an internal improvement 😄 .

There are a few rules that are still disabled internally but @bradzacher has mentioned would be good to enable internally:

// TODO - enable these new recommended rules
'@typescript-eslint/no-unsafe-assignment': 'off',
'@typescript-eslint/no-unsafe-call': 'off',
'@typescript-eslint/no-unsafe-member-access': 'off',
'@typescript-eslint/no-unsafe-return': 'off',
'@typescript-eslint/restrict-plus-operands': 'off',
'@typescript-eslint/restrict-template-expressions': 'off',
// TODO - enable this
'@typescript-eslint/naming-convention': 'off',
This was referenced Apr 11, 2021
Merged
Merged
Merged
Merged
@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Apr 19, 2021
This was referenced Jun 1, 2021
Merged
Merged
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Aug 1, 2021
Closed
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 7, 2021
Merged
@JoshuaKGoldberg JoshuaKGoldberg added the accepting prs Go ahead, send a pull request that resolves this issue label Oct 25, 2021
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 8, 2022
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove naming convention todo from eslintrc JoshuaKGoldberg/typescript-eslint
2 participants
@JoshuaKGoldberg @bradzacher