-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
no-floating-promises is not covered by eslint-plugin-promise #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Note that it is marked as 'unimplemented', not as 'implemented by plugin'. I think this is still planned. |
Thomas is correct, it is specifically this is marked as "🛑 = unimplemented", not "🔌 = in another plugin". We're happy to accept PRs to add this rule considering it needs type information about the called function. |
I think an issue should be opened for adding this rule to |
@w0rp yes, as bradzacher posted, this repo is accepting PRs. I'll send one in Soon™️ if someone else doesn't get to it first. You're welcome to give it a shot 😉 |
@w0rp Otherwise, the roadmap exists for a number of reasons, one of which being the tracking of things that could/should be added to the plugin, but are low priority (i.e. nobody has asked for them). We love new contributors, so if you want to give it a go, please feel very free! (as an aside - I closed this issue because it was about our docs being wrong [which they aren't], instead of being a feature request for the rule). |
Thank you, I have opened an issue for it now. |
The Roadmap lists
no-floating-promises
as "N/A" because of eslint-plugin-promise.But that plugin does not and has no plans to support floating promise detection:
eslint-community/eslint-plugin-promise#151
FWIW, this check caught a large number of bugs for us in our async code - it's an easy mistake to make.
The text was updated successfully, but these errors were encountered: