Skip to content

feat: Support 'latest' as ecmaVersion #3873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 21, 2021
Merged

feat: Support 'latest' as ecmaVersion #3873

merged 2 commits into from
Sep 21, 2021

Conversation

wafuwafu13
Copy link
Contributor

@wafuwafu13 wafuwafu13 commented Sep 12, 2021 •
edited
Loading

Done: #3857

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @wafuwafu13!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Sep 12, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit f6bf7c6. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin-internal
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx run-many --target=typecheck --all --parallel
#000000 nx test @typescript-eslint/parser
#000000 nx test @typescript-eslint/parser
#000000 nx test @typescript-eslint/experimental-utils
#000000 nx test @typescript-eslint/experimental-utils
#000000 nx test @typescript-eslint/scope-manager
#000000 nx test @typescript-eslint/scope-manager
#000000 nx run-many --target=build --all --parallel
#000000 nx test @typescript-eslint/parser
#000000 nx test @typescript-eslint/visitor-keys
#000000 nx test @typescript-eslint/visitor-keys
#000000 nx test @typescript-eslint/typescript-estree
#000000 nx test @typescript-eslint/typescript-estree

Sent with 💌 from NxCloud.

wafuwafu13
wafuwafu13 commented Sep 12, 2021
View reviewed changes
packages/types/src/parser-options.ts
@@ -26,7 +30,7 @@ interface ParserOptions {
globalReturn?: boolean;
jsx?: boolean;
};
ecmaVersion?: EcmaVersion;
ecmaVersion?: EcmaVersion | 'latest';
Copy link
Contributor Author

@wafuwafu13 wafuwafu13 Sep 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref: #3710 (comment)

let's remove latest from here and add it to the parser types as we're now handling it specifically within the parser

wafuwafu13
wafuwafu13 commented Sep 12, 2021
View reviewed changes
packages/types/src/parser-options.ts
| 2020;
| 2020
| 2021
| 2022;
Copy link
Contributor Author

@wafuwafu13 wafuwafu13 Sep 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref: #3710 (comment)

Added 2021 and 2022

wafuwafu13
wafuwafu13 commented Sep 12, 2021
View reviewed changes
packages/scope-manager/src/analyze.ts
* Convert ecmaVersion to lib.
* `'latest'` is converted to 1e8 at parser.
*/
function mapEcmaVersion(version: EcmaVersion | 1e8 | undefined): Lib {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref: #3710 (comment)

you don't need/want this check any more

@codecov
Copy link

codecov bot commented Sep 12, 2021 •
edited
Loading

Codecov Report

Merging #3873 (f6bf7c6) into master (4a88de2) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3873      +/-   ##
==========================================
- Coverage   92.70%   92.62%   -0.09%     
==========================================
  Files         329      310      -19     
  Lines       11534    10118    -1416     
  Branches     3257     2883     -374     
==========================================
- Hits        10693     9372    -1321     
+ Misses        368      312      -56     
+ Partials      473      434      -39
Flag Coverage Δ
unittest 92.62% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/scope-manager/src/analyze.ts 66.66% <ø> (ø)
...estree/src/create-program/createIsolatedProgram.ts
...ript-estree/src/create-program/createSourceFile.ts
packages/typescript-estree/src/simple-traverse.ts
packages/typescript-estree/src/node-utils.ts
...pt-estree/src/ts-estree/estree-to-ts-node-types.ts
...pt-estree/src/create-program/createWatchProgram.ts
...ckages/typescript-estree/src/jsx/xhtml-entities.ts
packages/typescript-estree/src/convert.ts
packages/typescript-estree/src/ts-estree/index.ts
... and 10 more

@bradzacher bradzacher added the enhancement New feature or request label Sep 13, 2021
@sindresorhus sindresorhus mentioned this pull request Sep 17, 2021
Merged
bradzacher
bradzacher approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher merged commit 25a42c0 into typescript-eslint:master Sep 21, 2021
This was referenced Oct 1, 2021
Closed
Closed
@sonallux sonallux mentioned this pull request Oct 3, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wafuwafu13 @bradzacher