Skip to content

fix(experimental-utils): fix isSetter's return type #3975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2021
Merged

fix(experimental-utils): fix isSetter's return type #3975

merged 1 commit into from
Oct 7, 2021

Conversation

MichaelDeBoey
Copy link
Contributor

No description provided.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @MichaelDeBoey!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Oct 6, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit b68f391. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
#000000 Node 10.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 10.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx run-many --target=typecheck --all --parallel
#000000 Node 10.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 10.x - nx test @typescript-eslint/experimental-utils
#000000 Node 10.x - nx test @typescript-eslint/scope-manager
#000000 Node 12.x - nx run-many --target=build --all --parallel
#000000 Node 10.x - nx test @typescript-eslint/visitor-keys
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 10.x - nx test @typescript-eslint/typescript-estree
#000000 Node 10.x - nx run-many --target=build --all --parallel
#000000 Node 12.x - nx test @typescript-eslint/scope-manager
#000000 Node 12.x - nx test @typescript-eslint/visitor-keys
#000000 Node 12.x - nx test @typescript-eslint/typescript-estree

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Oct 6, 2021 •
edited
Loading

Codecov Report

Merging #3975 (b68f391) into master (131cfbe) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3975      +/-   ##
==========================================
- Coverage   92.84%   92.78%   -0.06%     
==========================================
  Files         331      192     -139     
  Lines       11635     8763    -2872     
  Branches     3286     2692     -594     
==========================================
- Hits        10802     8131    -2671     
+ Misses        354      247     -107     
+ Partials      479      385      -94
Flag Coverage Δ
unittest 92.78% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ges/experimental-utils/src/ast-utils/predicates.ts 74.13% <ø> (ø)
packages/typescript-estree/src/ts-estree/index.ts
packages/visitor-keys/src/get-keys.ts
.../scope-manager/src/variable/ESLintScopeVariable.ts
...kages/scope-manager/src/lib/es2017.sharedmemory.ts
...ges/scope-manager/src/definition/DefinitionBase.ts
packages/scope-manager/src/lib/es5.ts
packages/scope-manager/src/lib/dom.ts
...s/scope-manager/src/lib/es2020.symbol.wellknown.ts
...ope-manager/src/definition/TSEnumNameDefinition.ts
... and 130 more

bradzacher
bradzacher approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher added the bug Something isn't working label Oct 7, 2021
@bradzacher bradzacher merged commit d256856 into typescript-eslint:master Oct 7, 2021
@MichaelDeBoey MichaelDeBoey deleted the patch-32 branch October 7, 2021 09:13
This was referenced Oct 12, 2021
Merged
Open
Merged
Merged
Merged
Open
Open
Open
Open
Open
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelDeBoey @bradzacher