Skip to content

[5.4.0] Typescript 4.4.4 (latest) not supported anymore #4164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
jlowcs opened this issue Nov 16, 2021 · 2 comments · Fixed by #4272
Closed
3 tasks done

[5.4.0] Typescript 4.4.4 (latest) not supported anymore #4164

jlowcs opened this issue Nov 16, 2021 · 2 comments · Fixed by #4272
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working good first issue Good for newcomers package: typescript-estree Issues related to @typescript-eslint/typescript-estree

Comments

@jlowcs
Copy link

jlowcs commented Nov 16, 2021

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have read the FAQ and my problem is not listed.

Repro

Using Typescript 4.4.4 (latest non-rc release)

Expected Result

linting should pass

Actual Result

node_modules/@typescript-eslint/typescript-estree/dist/ts-estree/estree-to-ts-node-types.d.ts:40:42 - error TS2694: Namespace 'ts' has no exported member 'AssertEntry'.

image

Additional Info

See above

Versions

package version
@typescript-eslint/typescript-estree 5.4.0
TypeScript 4.4.4
node 14.17.6
@jlowcs jlowcs added package: typescript-estree Issues related to @typescript-eslint/typescript-estree triage Waiting for team members to take a look labels Nov 16, 2021
@bradzacher bradzacher added bug Something isn't working good first issue Good for newcomers accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Nov 16, 2021
@bradzacher
Copy link
Member

We need to add a manual patch to

https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/typescript-estree/src/ts-estree/ts-nodes.ts#L3-L12

@bradzacher
Copy link
Member

We should really add an integration test which checks the types against an older version of TS to help us guard against this.

@bradzacher bradzacher mentioned this issue Nov 16, 2021
Closed
@lonyele lonyele mentioned this issue Dec 7, 2021
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working good first issue Good for newcomers package: typescript-estree Issues related to @typescript-eslint/typescript-estree
Projects
None yet
Milestone
No milestone
2 participants
@jlowcs @bradzacher