Skip to content

Split up linting internally #4226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Nov 26, 2021 · 3 comments · Fixed by #6038
Closed

Split up linting internally #4226

JoshuaKGoldberg opened this issue Nov 26, 2021 · 3 comments · Fixed by #6038
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Following up on #4197: our linting is running out of memory in CI and without that change would likely eventually run out of memory on developer computers too. The short term fix to up the --max-old-space-size for Node is a bandaid fix.

Short of the dedicated CLI discussed in #4183, #4197 (comment) / #4197 (comment) would be a better strategy:

"lint": "nx run-many --target=lint --all",
@JoshuaKGoldberg JoshuaKGoldberg added repo maintenance things to do with maintenance of the repo, and not with code/docs accepting prs Go ahead, send a pull request that resolves this issue labels Nov 26, 2021
@bradzacher
Copy link
Member

The important thing here would be to ensure that the lint output isn't interleaved or anything messy.

That was one big problem we had when running the tests in parallel and it's why we now run them serially.

@JamesHenry
Copy link
Member

JamesHenry commented Nov 29, 2021 •
edited
Loading

@bradzacher Even if they were interleaved in the raw output (which it usually isn't too badly because Nx prioritizes this internally within the process forking and output logic) we still have the advantage of Nx Cloud:

image

Each one of those each independently linked and the unique output for that task is isolated and reviewable at any time:

image

We could therefore also potentially switch the tests to run in parallel again with this. It's really with lerna run that we had the issue of the interleaved outputs I think

@bradzacher
Copy link
Member

If it handles it then for sure let's parallelise everything!

Cutting down on waiting time on the GH actions is a huge win.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Nov 19, 2022
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: switched repo lint to use nx run-many JoshuaKGoldberg/typescript-eslint
3 participants
@JamesHenry @JoshuaKGoldberg @bradzacher