[no-unused-vars] More missing detections #45

milesj · 2019-01-18T05:48:07Z

Repro

Run the linter on https://github.com/milesj/beemo

Some examples of it not working:

~~Type index access:~~ https://github.com/milesj/beemo/blob/master/packages/cli/src/CLI.ts#L58

11:32  warning  'DriverContext' is defined but never used    no-unused-vars

~~When an imported type is re-assigned and exported:~~ https://github.com/milesj/beemo/blob/master/packages/core/src/types.ts#L34 AND https://github.com/milesj/beemo/blob/master/packages/core/src/types.ts#L62

6:10  warning  'Tool' is defined but never used          no-unused-vars
7:10  warning  'ExecaReturns' is defined but never used  no-unused-vars

~~Imported type used in a generic intersection:~~ https://github.com/milesj/beemo/blob/master/packages/driver-babel/src/BabelDriver.ts#L46

  8:18  warning  'DriverArgs' is defined but never used  no-unused-vars
  9:10  warning  'BabelArgs' is defined but never used   no-unused-vars

Imported namespace reference: https://github.com/milesj/beemo/blob/master/packages/driver-webpack/src/types.ts#L9

  6:8  warning  'webpack' is defined but never used  no-unused-vars

Expected Result

They don't fail.

Actual Result

They do fail.

Additional Info

Versions

package	version
`eslint-plugin-typescript`	`0.14.0`
`typescript-eslint-parser`	`21.0.2`
`typescript`	`3.2.2`

The text was updated successfully, but these errors were encountered:

bradzacher · 2019-01-18T05:58:45Z

Hi @milesj, could you please try upgrading to 1.0.0-rc.3 and see if that works for these cases?

Also just a tip, when linking to files in your repo, instead of linking to master, link to a commit. The commit link's content won't change, but the link to master will change when you push.

j-f1 · 2019-01-18T10:53:08Z

(you can hit y to switch to a permalink for the current file)

SevInf · 2019-01-18T13:35:18Z

For me, this snippet still reports errors on 1.0.0-rc.3:

import { ExecutionResult } from 'graphql/execution/execute';
import { UnknownObject } from '../ts-utils';

export type RigelDispatch = <DataType extends UnknownObject>(
    action: Action<DataType>
) => Promise<ExecutionResult<DataType>>;

error  'UnknownObject' is defined but never used  typescript/no-unused-vars

milesj · 2019-01-18T18:26:37Z

I'll try the 1.0.0 version. typescript-eslint-parser has also been updated/deprecate, so I'll try that also.

milesj · 2019-01-19T02:28:13Z

Trying 1.0.0-rc3 and parser 22.0.0. It crashes on 2 repos with the following error:

TypeError: Cannot read property 'length' of undefined
    at TSInterfaceDeclaration (/Users/Miles/Sites/boost/node_modules/eslint-plugin-typescript/lib/rules/no-empty-interface.js:33:48)
    at listeners.(anonymous function).forEach.listener (/Users/Miles/Sites/boost/node_modules/eslint/lib/util/safe-emitter.js:45:58)
    at Array.forEach (<anonymous>)
    at Object.emit (/Users/Miles/Sites/boost/node_modules/eslint/lib/util/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (/Users/Miles/Sites/boost/node_modules/eslint/lib/util/node-event-generator.js:251:26)
    at NodeEventGenerator.applySelectors (/Users/Miles/Sites/boost/node_modules/eslint/lib/util/node-event-generator.js:280:22)
    at NodeEventGenerator.enterNode (/Users/Miles/Sites/boost/node_modules/eslint/lib/util/node-event-generator.js:294:14)
    at CodePathAnalyzer.enterNode (/Users/Miles/Sites/boost/node_modules/eslint/lib/code-path-analysis/code-path-analyzer.js:632:23)
    at nodeQueue.forEach.traversalInfo (/Users/Miles/Sites/boost/node_modules/eslint/lib/linter.js:750:28)
    at Array.forEach (<anonymous>)

The line in no-empty-interfaces is the following, which is different than this repo. Seems like an AST/tree mismatch.

                const heritage = node.heritage.length;

                if (node.body.body.length === 0 && heritage < 2) {

Also noticed that the eslint-plugin-typescript has typescript-eslint-parser as a dependency, which it probably shouldn't? Or at minimum should be a peer. It also has a peer dependency on ~3.1.1, which will be annoying to maintain/consume, ^3.1.0 is much easier.

armano2 · 2019-01-19T03:07:51Z

This is expected, there was a lot of changes in parser, and its not compatible with plugin, you have to wait for new release

armano2 · 2019-01-19T03:12:02Z

Please read #73

milesj · 2019-01-19T03:15:03Z

Yup, assumed that was the problem. Will report back in a week.

aserra54 · 2019-01-21T01:44:05Z

Not sure if I should piggy-back off of this issue, but another false negative I'm seeing is in interface declarations, e.g.

import { Foo, Bar } from 'qux';

export class Baz implements Foo {
  public bar: Bar;
}

Both Foo and Bar get tagged as being unused. Sample here:

https://github.com/aserra54/typescript-eslint-parser-no-unused-vars

armano2 · 2019-01-21T01:50:46Z

@aserra54 you are missing plugin https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/eslint-plugin

"extends": ["eslint:recommended", "plugin:@typescript-eslint/recommended"],

or atleast

{
  "parser": "@typescript-eslint/parser",
  "plugins": ["@typescript-eslint"],
  "rules": {
    "no-unused-vars": "off",
    "@typescript-eslint/no-unused-vars": "error"
  }
}

and you should move jsx to ecmaFeatures see https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/parser#eslintrcjson

milesj · 2019-01-21T04:48:09Z

Tested with the new @typescript-eslint packages. All of them are fixed except one -- when referencing an imported namespace. For example, i18next here.

import i18next from 'i18next';

export interface Translator extends i18next.i18n {}

Seems to trigger on both rules.

/Users/Miles/Sites/boost/packages/core/src/types.ts
  8:8  warning  'debug' is defined but never used    no-unused-vars
  8:8  error    'debug' is defined but never used    @typescript-eslint/no-unused-vars
  9:8  warning  'i18next' is defined but never used  no-unused-vars
  9:8  error    'i18next' is defined but never used  @typescript-eslint/no-unused-vars

SimenB · 2019-01-21T11:09:50Z

I'm getting false positives on React components.

// react.tsx
import * as React from 'react';
import { Heading2 } from 'some-place';

export const Comp: React.FunctionComponent = () => (
  <Heading2>Some content</Heading2>
);

/Users/simen/repos/monorepo/react.tsx
  2:10  warning  'Heading2' is defined but never used  @typescript-eslint/no-unused-vars

✖ 1 problem (0 errors, 1 warning)

config:

{
  "extends": ["plugin:@typescript-eslint/recommended"],
  "plugins": ["@typescript-eslint"]
}

(this creates a couple of more errors for rules I've turned off)

armano2 · 2019-01-21T12:03:14Z

You have to install and use eslint plugin React

SimenB · 2019-01-21T12:44:17Z

Ah! Fair enough 🙂 I've forgotten all about that plugin, gonna be awesome to be able to use it again 😅

JamesHenry transferred this issue from bradzacher/eslint-plugin-typescript Jan 18, 2019

bradzacher added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin awaiting response Issues waiting for a reply from the OP or another party labels Jan 18, 2019

armano2 removed the awaiting response Issues waiting for a reply from the OP or another party label Jan 21, 2019

armano2 mentioned this issue Jan 21, 2019

fix(eslint-plugin): improve detection of used vars in heritage #102

Merged

armano2 self-assigned this Jan 21, 2019

JamesHenry closed this as completed in #102 Jan 21, 2019

typescript-eslint locked as resolved and limited conversation to collaborators Feb 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[no-unused-vars] More missing detections #45

[no-unused-vars] More missing detections #45

milesj commented Jan 18, 2019 •

edited

Loading

bradzacher commented Jan 18, 2019

j-f1 commented Jan 18, 2019

SevInf commented Jan 18, 2019

milesj commented Jan 18, 2019

milesj commented Jan 19, 2019 •

edited

Loading

armano2 commented Jan 19, 2019 •

edited

Loading

armano2 commented Jan 19, 2019 •

edited

Loading

milesj commented Jan 19, 2019

aserra54 commented Jan 21, 2019

armano2 commented Jan 21, 2019 •

edited

Loading

milesj commented Jan 21, 2019 •

edited

Loading

SimenB commented Jan 21, 2019

armano2 commented Jan 21, 2019

SimenB commented Jan 21, 2019

[no-unused-vars] More missing detections #45

[no-unused-vars] More missing detections #45

Comments

milesj commented Jan 18, 2019 • edited Loading

bradzacher commented Jan 18, 2019

j-f1 commented Jan 18, 2019

SevInf commented Jan 18, 2019

milesj commented Jan 18, 2019

milesj commented Jan 19, 2019 • edited Loading

armano2 commented Jan 19, 2019 • edited Loading

armano2 commented Jan 19, 2019 • edited Loading

milesj commented Jan 19, 2019

aserra54 commented Jan 21, 2019

armano2 commented Jan 21, 2019 • edited Loading

milesj commented Jan 21, 2019 • edited Loading

SimenB commented Jan 21, 2019

armano2 commented Jan 21, 2019

SimenB commented Jan 21, 2019

milesj commented Jan 18, 2019 •

edited

Loading

milesj commented Jan 19, 2019 •

edited

Loading

armano2 commented Jan 19, 2019 •

edited

Loading

armano2 commented Jan 19, 2019 •

edited

Loading

armano2 commented Jan 21, 2019 •

edited

Loading

milesj commented Jan 21, 2019 •

edited

Loading