Skip to content

[@typescript-eslint/no-unnecessary-type-arguments] type argument automatically removed #4569

Closed
@nandi95

Description

@nandi95

I have a type that has a type argument which has to extend a certain type.
When I pass this type argument, it figures:

ESLint: This is the default value for this type parameter, so it can be omitted.(@typescript-eslint/no-unnecessary-type-arguments)

However the type argument while extending the expected type it is a type with extra things on it.

possibly related to #1224 ?

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have read the FAQ and my problem is not listed.

Repro

1 - clone https://github.com/upfrontjs/framework
2 - update ts-lint packages to the latest
3 - run npm run lint
The following should not have it's second type argument removed
https://github.com/upfrontjs/framework/blob/main/tests/Calliope/Factory/FactoryBuilder.test.ts#L17

{
  extends: [
        "eslint:recommended",
        "plugin:@typescript-eslint/all"
    ]
}

Expected Result

Type argument not to be removed

Actual Result

Type argument is removed

Additional Info
After updating to 5.12.0 from 5.11.0 my type arguments are incorrectly being removed
The PR that caused this change: #4543
The release: https://github.com/typescript-eslint/typescript-eslint/releases/tag/v5.12.0

Versions

package version
@typescript-eslint/eslint-plugin 5.12.0
@typescript-eslint/parser 5.12.0
TypeScript 4.5.5
ESLint 8.9.0
node 17.5.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    duplicateThis issue or pull request already existspackage: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions