Skip to content

feat(parser): add parserOptions.emitDecoratorMetadata #4646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2022
Merged

feat(parser): add parserOptions.emitDecoratorMetadata #4646

merged 1 commit into from
Mar 11, 2022

Conversation

xboy2012
Copy link
Contributor

@xboy2012 xboy2012 commented Mar 8, 2022

PR Checklist

Overview

emitDecoratorMetadata is added to ParserOptions as an optional param

The parser first try to use compilerOptions.emitDecoratorMetadata as it did before.

If parserOptions.project is set, then parserOptions.emitDecoratorMetadata is used.

@nx-cloud
Copy link

nx-cloud bot commented Mar 8, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit d799cd2. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 41 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @xboy2012!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Mar 8, 2022 •
edited
Loading

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: d799cd2

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/622b59fb84e9730009c34719

😎 Browse the preview: https://deploy-preview-4646--typescript-eslint.netlify.app

bradzacher
bradzacher requested changes Mar 8, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for hopping on this so fast!

please make sure this is also documented in the readme:
https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/parser#configuration

@bradzacher bradzacher added the enhancement New feature or request label Mar 8, 2022
@bradzacher bradzacher changed the title feat: use emitDecoratorMetadata from parserOptions feat(parser): add parserOptions.emitDecoratorMetadata Mar 8, 2022
@codecov
Copy link

codecov bot commented Mar 10, 2022 •
edited
Loading

Codecov Report

Merging #4646 (eebca34) into main (cf325ce) will decrease coverage by 1.59%.
The diff coverage is 100.00%.

❗ Current head eebca34 differs from pull request most recent head d799cd2. Consider uploading reports for the commit d799cd2 to get more accurate results

@@            Coverage Diff             @@
##             main    #4646      +/-   ##
==========================================
- Coverage   94.25%   92.65%   -1.60%     
==========================================
  Files         151      315     +164     
  Lines        7971    11259    +3288     
  Branches     2573     3329     +756     
==========================================
+ Hits         7513    10432    +2919     
- Misses        262      563     +301     
- Partials      196      264      +68
Flag Coverage Δ
unittest 92.65% <100.00%> (-1.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/typescript-estree/src/convert.ts 98.37% <100.00%> (ø)
packages/scope-manager/src/lib/es2022.error.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/variable/index.ts 50.00% <0.00%> (ø)
packages/scope-manager/src/lib/es2022.array.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/referencer/index.ts 100.00% <0.00%> (ø)
...ckages/scope-manager/src/referencer/VisitorBase.ts 87.87% <0.00%> (ø)
packages/scope-manager/src/lib/es2017.string.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/lib/es2022.full.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/lib/esnext.bigint.ts 100.00% <0.00%> (ø)
...src/definition/ImplicitGlobalVariableDefinition.ts 100.00% <0.00%> (ø)
... and 155 more

@xboy2012
Copy link
Contributor Author

ready to merge now. @bradzacher

@xboy2012 xboy2012 requested a review from bradzacher March 11, 2022 02:32
bradzacher
bradzacher approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking good to me - thanks for doing this!

@bradzacher bradzacher merged commit e3dd343 into typescript-eslint:main Mar 11, 2022
This was linked to issues Mar 11, 2022
[consistent-type-imports] support decorator metaData without specifying project #4638
Closed
[consistent-type-imports] Using with --fix changes constructor imports to type imports in nest and angular #3630
Closed
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Mar 18, 2022
Update typescript-eslint monorepo to v5.15.0 (#1225)
aecca06 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.14.0` -> `5.15.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.14.0/5.15.0) |
| [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.14.0` -> `5.15.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.14.0/5.15.0) |

---

### Release Notes

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>

### [`v5.15.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5150-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5140v5150-2022-03-14)

[Compare Source](typescript-eslint/typescript-eslint@v5.14.0...v5.15.0)

##### Features

-   **parser:** add `parserOptions.emitDecoratorMetadata` ([#&#8203;4646](typescript-eslint/typescript-eslint#4646)) ([e3dd343](typescript-eslint/typescript-eslint@e3dd343))

</details>

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>

### [`v5.15.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5150-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5140v5150-2022-03-14)

[Compare Source](typescript-eslint/typescript-eslint@v5.14.0...v5.15.0)

##### Features

-   **parser:** add `parserOptions.emitDecoratorMetadata` ([#&#8203;4646](typescript-eslint/typescript-eslint#4646)) ([e3dd343](typescript-eslint/typescript-eslint@e3dd343))

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1225
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@xboy2012 @bradzacher