Skip to content

Set up plan to continue onboarding to Nx #4665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Mar 10, 2022 · 3 comments
Closed

Set up plan to continue onboarding to Nx #4665

JoshuaKGoldberg opened this issue Mar 10, 2022 · 3 comments
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Overview

@JamesHenry mentioned in #4661 that we're only partially onboarded to nx: #4661 (comment)

The only reason I didn't do this initially was to slowly dip everyone's toes into the Nx waters and change things as little as possible

We've had our toes in the water for a while. Per https://nx.dev/guides/lerna-and-nx it seems like we can onboard more fully to Nx and rely less on Lerna. What else is there to do?

If the continued switch would be straightforward, maybe this issue can track it? If not, should we set up a project and split up issues?
@JoshuaKGoldberg JoshuaKGoldberg added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Mar 10, 2022
@JamesHenry JamesHenry self-assigned this Mar 10, 2022
@JamesHenry
Copy link
Member

I've assigned myself and have it underway 👍

@bradzacher bradzacher added the accepting prs Go ahead, send a pull request that resolves this issue label Mar 10, 2022
@JamesHenry JamesHenry mentioned this issue Mar 21, 2022
Closed
@JamesHenry JamesHenry mentioned this issue Apr 4, 2022
Merged
@JoshuaKGoldberg
Copy link
Member Author

@JamesHenry for visibility, would you be open to posting that plan here?

@JoshuaKGoldberg
Copy link
Member Author

Ok! @JamesHenry and I streamed on Twitch [YouTube link that won't expire after 2 months] and came up with this rough plan of attack:

  1. Repo: Bump Nx to the latest version #6141
  2. Repo: Migrate to Nx executors for more commands #6142

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JamesHenry @JoshuaKGoldberg @bradzacher