Skip to content

parser typescript declarations are unusable #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
43081j opened this issue May 13, 2019 · 2 comments · Fixed by #527
Closed

parser typescript declarations are unusable #523

43081j opened this issue May 13, 2019 · 2 comments · Fixed by #527
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge enhancement New feature or request package: parser Issues related to @typescript-eslint/parser

Comments

@43081j
Copy link
Contributor

43081j commented May 13, 2019

I know you've mentioned the types before as being in progress still (and likely to change), but figured this is its own issue.

Currently the parser types are unusable as eslint-visitor-keys has no declaration file in the shipped package.

The same seems to apply for eslint-scope types.

This means nobody using typescript can successfully import the parser package without installing the dependencies themselves (and copying your custom types across).

@43081j 43081j added package: parser Issues related to @typescript-eslint/parser triage Waiting for team members to take a look labels May 13, 2019
@bradzacher
Copy link
Member

It's hard for us to know exactly how people are consuming our packages; i.e. I didn't realise people were consuming the parser package directly from within typescript code.

More than happy to accept PRs if there's something that's hard to use for your use case.
Esp for something like eslint-scope, the idea would just be to move it to the utils package.

@bradzacher bradzacher added enhancement New feature or request and removed triage Waiting for team members to take a look labels May 13, 2019
@43081j
Copy link
Contributor Author

43081j commented May 13, 2019

In my case i'm trying to consume the parser module for test purposes (i need to parse a block of code in order to do some assertions on the resulting AST and what not).

It seems to be because the dependant types are devDependencies but im not too sure as I haven't run into this problem before.

@bradzacher bradzacher added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label May 16, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge enhancement New feature or request package: parser Issues related to @typescript-eslint/parser
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants