Skip to content

Bug: [prefer-as-const] Rule doesn't support class properties #5405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
undsoft opened this issue Jul 31, 2022 · 2 comments · Fixed by #5413
Closed
4 tasks done

Bug: [prefer-as-const] Rule doesn't support class properties #5405

undsoft opened this issue Jul 31, 2022 · 2 comments · Fixed by #5413
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working good first issue Good for newcomers package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@undsoft
Copy link
Contributor

undsoft commented Jul 31, 2022 •
edited
Loading

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=4.7.4&sourceType=module&code=MYGwhgzhAEAKCWAvRZoG8BQ1oAdIBcwAuaAcjwkNOgF4yKqBuDAXyA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Y6RAM0WloENktMgHsmyfOii9oI6JHBgAviCVA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA

Repro Code

class Pizza {
  pasta: 'pasta' = 'pasta';
}

ESLint Config

module.exports = {
  parser: "@typescript-eslint/parser",
  rules: {
    "@typescript-eslint/prefer-as-const": "error"
  },
};

tsconfig

{
  "compilerOptions": {
    // ...
  }
}

Expected Result

Expect an error and a suggestion to use as const instead of explicit type.

Actual Result

No error.

Additional Info

No response

Versions

package version
@typescript-eslint/eslint-plugin 5.31.0
@typescript-eslint/parser X.Y.Z
TypeScript 4.7.4
ESLint 8.15.0
node X.Y.Z
@undsoft undsoft added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look labels Jul 31, 2022
@undsoft
Copy link
Contributor Author

undsoft commented Jul 31, 2022

Ready to make a PR.

@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Aug 1, 2022
@JoshuaKGoldberg
Copy link
Member

Emperor Palpatine from Star Wars Episode 3 saying "Do it."

@undsoft undsoft mentioned this issue Aug 1, 2022
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working good first issue Good for newcomers package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(eslint-plugin): [prefer-as-const] adds support for class properties undsoft/typescript-eslint
2 participants
@undsoft @JoshuaKGoldberg