Skip to content

Repo: Fail tests on console logs #5532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Aug 23, 2022 · 0 comments · Fixed by #5533
Closed

Repo: Fail tests on console logs #5532

JoshuaKGoldberg opened this issue Aug 23, 2022 · 0 comments · Fixed by #5533
Labels
accepting prs Go ahead, send a pull request that resolves this issue enhancement New feature or request repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

#5525 would have been caught if we added logic to tests to fail them on console logs.

Example package: https://www.npmjs.com/package/console-fail-test
@JoshuaKGoldberg JoshuaKGoldberg added triage Waiting for team members to take a look repo maintenance things to do with maintenance of the repo, and not with code/docs accepting prs Go ahead, send a pull request that resolves this issue enhancement New feature or request and removed triage Waiting for team members to take a look labels Aug 23, 2022
This was referenced Aug 23, 2022
Merged
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue enhancement New feature or request repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fail tests that log to the console JoshuaKGoldberg/typescript-eslint
1 participant
@JoshuaKGoldberg