Skip to content

Repo: Enable react-hooks/exhaustive-deps in website ESLint config #5549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Aug 26, 2022 · 0 comments · Fixed by #5663
Closed

Repo: Enable react-hooks/exhaustive-deps in website ESLint config #5549

JoshuaKGoldberg opened this issue Aug 26, 2022 · 0 comments · Fixed by #5663
Labels
accepting prs Go ahead, send a pull request that resolves this issue package: website Issues related to the @typescript-eslint website repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

typescript-eslint/packages/website/.eslintrc.js

Line 25 in 39829c0

'react-hooks/exhaustive-deps': 'off', // TODO: enable it later

Tracking issue for the TODO: let's enable that lint rule, yeah?
@JoshuaKGoldberg JoshuaKGoldberg added triage Waiting for team members to take a look repo maintenance things to do with maintenance of the repo, and not with code/docs package: website Issues related to the @typescript-eslint website labels Aug 26, 2022
@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Sep 4, 2022
This was referenced Sep 15, 2022
Closed
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue package: website Issues related to the @typescript-eslint website repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(website): Enable react-hooks exhaustive deps rules amorimr/typescript-eslint
1 participant
@JoshuaKGoldberg