Skip to content

Enhancement: [no-unsafe-declaration-merging] Switch to scope manager #5854

Closed
@JoshuaKGoldberg

Description

@JoshuaKGoldberg

Before You File a Proposal Please Confirm You Have Done The Following...

My proposal is suitable for this project

  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Link to the rule's documentation

https://typescript-eslint.io/rules/no-unsafe-declaration-merging/

Description

Per #5840 (comment):

We should actually be able to do this without type info and just with the scope analysis APIs.

Not using type information where possible is preferable for rules. See https://typescript-eslint.io/docs/linting/typed-linting/.

Fail

(same as before)

Pass

(same as before)

Additional Info

This rule is only in the strict config, not one of the recommended ones (yet). So it wouldn't be a breaking change to use the scope manager.

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuepackage: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions