feat(scope-manager): ignore ECMA version #5881

JoshuaKGoldberg · 2022-10-25T14:46:50Z

BREAKING CHANGE:
Removes part of the public API for the parser and scope-manager.

PR Checklist

Addresses an existing open issue: fixes [scope-manager] should ignore parserOptions.ecmaVersion #2900
That issue was marked as accepting prs
Steps in CONTRIBUTING.md were taken

Overview

Per the issue, ignores ecmaVersion in the options, and assumes it's always ESNext.

typescript-eslint · 2022-10-25T14:46:53Z

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

nx-cloud · 2022-10-25T14:46:53Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 04e8bed. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

netlify · 2022-10-25T14:47:25Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`04e8bed`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/63589dbb2fad4500083a4ef6
😎 Deploy Preview	https://deploy-preview-5881--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

packages/scope-manager/src/ScopeManager.ts

codecov · 2022-10-25T15:03:36Z

Codecov Report

Merging #5881 (70e73fb) into main (2019c2f) will decrease coverage by 0.01%.
The diff coverage is 57.14%.

❗ Current head 70e73fb differs from pull request most recent head 04e8bed. Consider uploading reports for the commit 04e8bed to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5881      +/-   ##
==========================================
- Coverage   91.36%   91.34%   -0.02%     
==========================================
  Files         364      364              
  Lines       12134    12123      -11     
  Branches     3540     3530      -10     
==========================================
- Hits        11086    11074      -12     
- Misses        748      750       +2     
+ Partials      300      299       -1

Flag	Coverage Δ
unittest	`91.34% <57.14%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/scope-manager/src/ScopeManager.ts	`77.21% <0.00%> (-2.54%)`	⬇️
packages/scope-manager/src/analyze.ts	`57.89% <0.00%> (-7.49%)`	⬇️
...ackages/scope-manager/src/referencer/Referencer.ts	`95.90% <100.00%> (-0.07%)`	⬇️

bradzacher

we can also remove the code from higher up the chain!

start from here and work your way down!
https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/src/parser.ts#L108

packages/scope-manager/src/ScopeManager.ts

bradzacher · 2022-10-26T01:14:27Z

packages/scope-manager/src/analyze.ts

@@ -122,7 +95,7 @@ function analyze(
    jsxFragmentName:
      providedOptions?.jsxFragmentName ?? DEFAULT_OPTIONS.jsxFragmentName,
    sourceType: providedOptions?.sourceType ?? DEFAULT_OPTIONS.sourceType,
-    lib: providedOptions?.lib ?? [mapEcmaVersion(ecmaVersion)],


Hmmm. I wonder if maybe I was too over-zealous with my recommendation to cull higher?

Having this auto-resolved is a really nice property. For the most part it shouldn't cause any issues for people (it just includes a few more global variables for people using rules like no-undef or no-use-before-define), but there might be edge cases?

Hmm. WDYT? I'm torn on if it's worth the code.

Neither of those are rules we recommend folks use - and folks should generally always be in >=ES2021 or so these days. I say let's kill them for now, and use the RC period to see if anybody notices! 🔪

Oh I will mark this as a breaking change now though.

JoshuaKGoldberg · 2022-10-26T02:53:22Z

AGH the branch change to v6 didn't go through. 🤦

This reverts commit 3b8d449.

Revert "feat(scope-manager): ignore ECMA version (#5881)" This reverts commit 3b8d449.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.41.0` -> `5.42.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.41.0/5.42.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.41.0` -> `5.42.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.41.0/5.42.0) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)</summary> ### [`v5.42.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#5420-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5410v5420-2022-10-31) [Compare Source](typescript-eslint/typescript-eslint@v5.41.0...v5.42.0) ##### Bug Fixes - **ast-spec:** add TSQualifiedName to TypeNode union ([#5906](typescript-eslint/typescript-eslint#5906)) ([5c316c1](typescript-eslint/typescript-eslint@5c316c1)) - **eslint-plugin:** \[no-extra-parens] handle type assertion in extends clause ([#5901](typescript-eslint/typescript-eslint#5901)) ([8ed7219](typescript-eslint/typescript-eslint@8ed7219)) ##### Features - **eslint-plugin:** \[member-ordering] add natural sort order ([#5662](typescript-eslint/typescript-eslint#5662)) ([1eaae09](typescript-eslint/typescript-eslint@1eaae09)) - **eslint-plugin:** \[no-invalid-void-type] better report message for void used as a constituent inside a function return type ([#5274](typescript-eslint/typescript-eslint#5274)) ([d806bda](typescript-eslint/typescript-eslint@d806bda)) </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/parser)</summary> ### [`v5.42.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#5420-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5410v5420-2022-10-31) [Compare Source](typescript-eslint/typescript-eslint@v5.41.0...v5.42.0) ##### Features - **scope-manager:** ignore ECMA version ([#5881](typescript-eslint/typescript-eslint#5881)) ([3b8d449](typescript-eslint/typescript-eslint@3b8d449)) ##### Reverts - Revert "feat(scope-manager): ignore ECMA version" ([#5888](typescript-eslint/typescript-eslint#5888)) ([2ee81df](typescript-eslint/typescript-eslint@2ee81df)), closes [#5888](typescript-eslint/typescript-eslint#5888) [#5881](typescript-eslint/typescript-eslint#5881) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1619 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

feat(scope-manager): ignore ECMA version

a5f7bd4

JoshuaKGoldberg commented Oct 25, 2022

View reviewed changes

packages/scope-manager/src/ScopeManager.ts Show resolved Hide resolved

JoshuaKGoldberg marked this pull request as ready for review October 25, 2022 14:59

JoshuaKGoldberg requested a review from bradzacher October 25, 2022 14:59

bradzacher requested changes Oct 25, 2022

View reviewed changes

packages/scope-manager/src/ScopeManager.ts Show resolved Hide resolved

bradzacher added the enhancement New feature or request label Oct 25, 2022

JoshuaKGoldberg added 3 commits October 25, 2022 19:25

Remove much more

5aa6a27

Fix WebLinter lint

e42f754

Merge branch 'main' into scope-manager-ignore-ecma-version

70e73fb

JoshuaKGoldberg requested a review from bradzacher October 25, 2022 23:38

bradzacher approved these changes Oct 26, 2022

View reviewed changes

Merge branch 'main' into scope-manager-ignore-ecma-version

04e8bed

JoshuaKGoldberg added the breaking change This change will require a new major version to be released label Oct 26, 2022

JoshuaKGoldberg merged commit 3b8d449 into typescript-eslint:main Oct 26, 2022

JoshuaKGoldberg added a commit that referenced this pull request Oct 26, 2022

Revert "feat(scope-manager): ignore ECMA version (#5881)"

39d58a6

This reverts commit 3b8d449.

JoshuaKGoldberg mentioned this pull request Oct 26, 2022

Revert "feat(scope-manager): ignore ECMA version" #5888

Merged

JoshuaKGoldberg added a commit that referenced this pull request Oct 26, 2022

Revert "feat(scope-manager): ignore ECMA version" (#5888)

2ee81df

Revert "feat(scope-manager): ignore ECMA version (#5881)" This reverts commit 3b8d449.

JoshuaKGoldberg deleted the scope-manager-ignore-ecma-version branch October 26, 2022 03:13

github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(scope-manager): ignore ECMA version #5881

feat(scope-manager): ignore ECMA version #5881

JoshuaKGoldberg commented Oct 25, 2022 •

edited

Loading

typescript-eslint bot commented Oct 25, 2022

nx-cloud bot commented Oct 25, 2022 •

edited

Loading

netlify bot commented Oct 25, 2022 •

edited

Loading

codecov bot commented Oct 25, 2022 •

edited

Loading

bradzacher left a comment

bradzacher Oct 26, 2022

JoshuaKGoldberg Oct 26, 2022

JoshuaKGoldberg Oct 26, 2022

JoshuaKGoldberg commented Oct 26, 2022

feat(scope-manager): ignore ECMA version #5881

feat(scope-manager): ignore ECMA version #5881

Conversation

JoshuaKGoldberg commented Oct 25, 2022 • edited Loading

PR Checklist

Overview

typescript-eslint bot commented Oct 25, 2022

nx-cloud bot commented Oct 25, 2022 • edited Loading

☁️ Nx Cloud Report

netlify bot commented Oct 25, 2022 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

codecov bot commented Oct 25, 2022 • edited Loading

Codecov Report

bradzacher left a comment

Choose a reason for hiding this comment

bradzacher Oct 26, 2022

Choose a reason for hiding this comment

JoshuaKGoldberg Oct 26, 2022

Choose a reason for hiding this comment

JoshuaKGoldberg Oct 26, 2022

Choose a reason for hiding this comment

JoshuaKGoldberg commented Oct 26, 2022

JoshuaKGoldberg commented Oct 25, 2022 •

edited

Loading

nx-cloud bot commented Oct 25, 2022 •

edited

Loading

netlify bot commented Oct 25, 2022 •

edited

Loading

codecov bot commented Oct 25, 2022 •

edited

Loading