Skip to content

Bug: [prefer-optional-chain] Unexpected member property type: ThisExpression #6024

Closed
@sviat9440

Description

@sviat9440

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=4.8.4&sourceType=module&code=MYGwhgzhAECC0G8CwAoa0DEYDcr0YCNcU9oBbAUwBcALAewBMAKASkVPQEsAzaJgQlqcIAOizQAPhOiCawsQTbI06VQCdqAVzUA7YqugBfUsZSmgA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Y6RAM0WloHsalfkwCG8WmQAWo5uii9o-aJHBgAviHVA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3QAacDUjoAHoizJ46IngCGqACL9YmNXl3Cwo9FIC+IM0A

Repro Code

class A {
  #a;
  #b;

  method() {
    if (!this.#a || !this.#b) {
      return;
    }
  }
}

ESLint Config

module.exports = {
  "rules": {
    "@typescript-eslint/prefer-optional-chain": "error"
  }
}

tsconfig

{
  "compilerOptions": {
    "strictNullChecks": true,
    "experimentalDecorators": true
  }
}

Expected Result

No errors

Actual Result

Unexpected member property type: ThisExpression

Additional Info

This is a regression of 5.43.0. In version 5.42.1 all works correctly.
I suppose it was a consequence of these changes: #5594 @omril1

Versions

package version
@typescript-eslint/eslint-plugin 5.43.0
@typescript-eslint/parser 5.43.0
TypeScript 4.8.4
ESLint 8.15.0
node web

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuebugSomething isn't workinggood first issueGood for newcomerspackage: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions