Skip to content

Rule rename: no-extraneous-class -> no-class-as-namespace #6035

Closed
@JoshuaKGoldberg

Description

@JoshuaKGoldberg

Overview

Porting context from #6022 > #6022 (comment):

A number of the no- rules make sense as things that won't be turned on and have no inverse, so a blanket rule against no- prefixes is a bad idea.
I agree though that it makes sense for us to advise against that naming if it's feasible that we will add inverse functionality to a rule.

@typescript-eslint/no-extraneous-class is mentioned as a potential rule to rename:

  • I doubt anyone would ever want the inverse of this unless they absolutely love java.
  • would be good to rename this so it's clearer though (no-class-as-namespace?)

Personally, I slightly prefer no-extraneous-class because it directly implies that the practice is bad. no-class-as-namespace just says what the practice is, without that explicit negative connotation. But maybe that's just me - posting this issue to hear other folks' thoughts!

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestpackage: eslint-pluginIssues related to @typescript-eslint/eslint-plugintriageWaiting for team members to take a look

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions