Skip to content

Bug: [strict-boolean-expression] using string literal union bypasses allowString: false #6624

Closed
@wolverineks

Description

@wolverineks

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.0.1-rc&sourceType=module&code=MYewdgzgLgBARgQwE4wLwwBQDMQgFwwBEChMAPkaRQK5gAmAplgJZgN0CUaAfDAN4AoGDGZZMAQhwgug4cNCQQAGwYA6JSADm2XByEwAvgINA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6ZfKsugIwHs+SAIZN6AD2LQUySnyaoMAbXDYciaND7RIKiAF0VAXxCGgA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA

Repro Code

const bar = (foo: "a" | "" | undefined) => {
  if (!foo) {
    console.log(foo)
  }
}

ESLint Config

{
  "rules": {
    "@typescript-eslint/strict-boolean-expressions": [
      "error"
    ]
  }
}

tsconfig

{
  "compilerOptions": {
    "strictNullChecks": true
  }
}

Expected Result

i expect line 2 to error with

Unexpected nullable string value in conditional. Please handle the nullish/empty cases explicitly.

Actual Result

no error

Additional Info

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuebugSomething isn't workingpackage: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions