Skip to content

Repo: Enable prefer-string-starts-with internally #7338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Jul 27, 2023 · 1 comment · Fixed by #9244
Closed

Repo: Enable prefer-string-starts-with internally #7338

JoshuaKGoldberg opened this issue Jul 27, 2023 · 1 comment · Fixed by #9244
Assignees
@JoshuaKGoldberg
Labels
locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. repo maintenance things to do with maintenance of the repo, and not with code/docs team assigned A member of the typescript-eslint team should work on this.

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

Our .eslintrc.js generally has a line that looks something like:

typescript-eslint/.eslintrc.js

Lines 56 to 58 in 593d37f

// TODO(#7138): Investigate enabling these soon ✨
'@typescript-eslint/consistent-indexed-object-style': 'off',
'@typescript-eslint/prefer-nullish-coalescing': 'off',

Filing this tracking issue to investigate enabling them. For each, we'll want to:

  1. Try enabling it in a commit/branch/PR
  2. Fix up any legitimate complaints it points out
  3. If it points too many things incorrectly, either:
    • File bug/feature issues on the rule to help it improve
    • Keep it disabled altogether
@JoshuaKGoldberg JoshuaKGoldberg added repo maintenance things to do with maintenance of the repo, and not with code/docs accepting prs Go ahead, send a pull request that resolves this issue labels Jul 27, 2023
@nevvada nevvada mentioned this issue Jul 28, 2023
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg changed the title Repo: Investigate enabled our rules that are disabled in our .eslintrc.js Repo: Investigate enabling our rules that are disabled in our .eslintrc.js Aug 7, 2023
This was referenced Oct 25, 2023
Merged
Merged
Merged
Merged
Merged
This was referenced Nov 19, 2023
Merged
Merged
This was referenced Nov 29, 2023
Merged
Merged
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Feb 4, 2024
Closed
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg changed the title Repo: Investigate enabling our rules that are disabled in our .eslintrc.js Repo: Enable prefer-string-starts-with internally Jun 4, 2024
@JoshuaKGoldberg
Copy link
Member Author

At this point, it's just two rules left:

typescript-eslint/eslint.config.mjs

Lines 106 to 108 in 5b78f22

// TODO(#7130): Investigate changing these in or removing these from presets
'@typescript-eslint/no-confusing-void-expression': 'off',
'@typescript-eslint/prefer-string-starts-ends-with': 'off',

no-confusing-void-expression is blocked & tracked by #8538. Retargeting this issue for prefer-string-starts-with.

@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jun 4, 2024
@JoshuaKGoldberg JoshuaKGoldberg added team assigned A member of the typescript-eslint team should work on this. and removed accepting prs Go ahead, send a pull request that resolves this issue labels Jun 4, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jun 4, 2024
Merged
3 tasks
@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Jun 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. repo maintenance things to do with maintenance of the repo, and not with code/docs team assigned A member of the typescript-eslint team should work on this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: enable prefer-string-starts-ends-with internally JoshuaKGoldberg/typescript-eslint
1 participant
@JoshuaKGoldberg