Skip to content

💀 Rule deletions: formatting (layout) rules #8074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshuaKGoldberg opened this issue Dec 15, 2023 · 1 comment
Closed

💀 Rule deletions: formatting (layout) rules #8074

JoshuaKGoldberg opened this issue Dec 15, 2023 · 1 comment
Labels
accepting prs Go ahead, send a pull request that resolves this issue breaking change This change will require a new major version to be released locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Milestone

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Dec 15, 2023

Overview

#8072 tracks deprecating formatting rules as a non-breaking change. As a followup, this issue tracks removing those formatting rules from typescript-eslint altogether. Those rules now live in eslint-stylistic and as such don't need to exist in this plugin anymore.

As a breaking change for our next major version, let's:

  • Delete the files! 🔪
  • Look into removing the 'layout' property from our internal rule meta.type type union
    • Or at least that this should only impact internal rules. We shouldn't negatively impact eslint-stylistic or other consumers of our custom rule APIs
@JoshuaKGoldberg JoshuaKGoldberg added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin blocked by another PR PRs which are ready to go but waiting on another PR labels Dec 15, 2023
@JoshuaKGoldberg JoshuaKGoldberg added this to the 7.0.0 milestone Dec 15, 2023
@JoshuaKGoldberg JoshuaKGoldberg added breaking change This change will require a new major version to be released and removed blocked by another PR PRs which are ready to go but waiting on another PR labels Dec 24, 2023
@bradzacher bradzacher added the accepting prs Go ahead, send a pull request that resolves this issue label Feb 20, 2024
@JoshuaKGoldberg JoshuaKGoldberg changed the title 💀 Rule deletions: formatting rules 💀 Rule deletions: formatting (layout) rules Apr 4, 2024
@JoshuaKGoldberg
Copy link
Member Author

#8833 was merged into the v8 branch. ✅

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2024
@bradzacher bradzacher added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Apr 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepting prs Go ahead, send a pull request that resolves this issue breaking change This change will require a new major version to be released locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Development

No branches or pull requests

2 participants