Skip to content

Enhancement: Default allowAutomaticSingleRunInference to true #8121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
JoshuaKGoldberg opened this issue Dec 24, 2023 · 3 comments · Fixed by #8922
Closed
4 tasks done

Enhancement: Default allowAutomaticSingleRunInference to true #8121

JoshuaKGoldberg opened this issue Dec 24, 2023 · 3 comments · Fixed by #8922
Assignees
@JoshuaKGoldberg
Labels
accepting prs Go ahead, send a pull request that resolves this issue enhancement New feature or request locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. performance Issues regarding performance
Milestone
8.0.0

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Dec 24, 2023 •
edited
Loading

Before You File a Proposal Please Confirm You Have Done The Following...

Relevant Package

typescript-estree

My proposal is suitable for this project

  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Description

Reposting #6176: we've heard from users that the allowAutomaticSingleRunInference option can significantly improve linting performance. And other than --fix mode project references (#3851) we haven't heard any new reports about it causing issues.

Let's turn the inference on by default!

Additional Info

Marking as blocked on #3851 to start. Adding to the v7 v8 milestone as well.
@JoshuaKGoldberg JoshuaKGoldberg added enhancement New feature or request triage Waiting for team members to take a look labels Dec 24, 2023
@JoshuaKGoldberg JoshuaKGoldberg added this to the 7.0.0 milestone Dec 24, 2023
@liuxingbaoyu
Copy link
Contributor

FYI: This has obvious benefits in Babel.
babel/babel#16029

@JoshuaKGoldberg JoshuaKGoldberg added blocked by another issue Issues which are not ready because another issue needs to be resolved first and removed triage Waiting for team members to take a look labels Dec 26, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 26, 2023
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 5, 2024
Open
@JoshuaKGoldberg JoshuaKGoldberg added the performance Issues regarding performance label Jan 30, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Apr 4, 2024
@JoshuaKGoldberg JoshuaKGoldberg changed the title Enhancement: Default allowAutomaticSingleRunInference to true in v7 Enhancement: Default allowAutomaticSingleRunInference to true Apr 4, 2024
@JoshuaKGoldberg
Copy link
Member Author

JoshuaKGoldberg commented Apr 15, 2024 •
edited
Loading

Now that we have a v8 branch, I feel comfortable sending a PR for this. We'll still want to resolve #3851 before v8 though.

Edit: resolved! 🚀

@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed blocked by another issue Issues which are not ready because another issue needs to be resolved first labels Apr 15, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Apr 15, 2024
Merged
3 tasks
@JoshuaKGoldberg
Copy link
Member Author

#8922 was merged into v8. ✅

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2024
@bradzacher bradzacher added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Apr 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
accepting prs Go ahead, send a pull request that resolves this issue enhancement New feature or request locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. performance Issues regarding performance
Projects
None yet
Milestone
8.0.0
3 participants
@JoshuaKGoldberg @bradzacher @liuxingbaoyu