Skip to content

Repo: Add a util for determining whether a node is a specific identifier #8327

New issue
New issue
Closed as not planned
Closed as not planned
Repo: Add a util for determining whether a node is a specific identifier#8327
Labels
locked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.repo maintenancethings to do with maintenance of the repo, and not with code/docswontfixThis will not be worked on
@StyleShit

Description

@StyleShit
StyleShit
opened on Jan 31, 2024

Suggestion

Splits from #8295 (comment)

The proposal is to go over all of the places where we check if a node is a specific identifier and use a util for that. Here are a couple of examples of places we do this:

typescript-eslint/packages/eslint-plugin/src/rules/array-type.ts

Lines 31 to 34 in 82cb9dd

if (
node.typeName.type === AST_NODE_TYPES.Identifier &&
node.typeName.name === 'Array'
) {

typescript-eslint/packages/eslint-plugin/src/rules/consistent-type-assertions.ts

Lines 102 to 105 in a54a60b

return (
node.typeName.type === AST_NODE_TYPES.Identifier &&
node.typeName.name === 'const'
);

typescript-eslint/packages/eslint-plugin/src/rules/no-explicit-any.ts

Lines 110 to 114 in e77616b

return (
node.type === AST_NODE_TYPES.TSTypeReference &&
node.typeName.type === AST_NODE_TYPES.Identifier &&
['Array', 'ReadonlyArray'].includes(node.typeName.name)
);

I think we can take inspiration from this existing function and extract it to a util:

typescript-eslint/packages/eslint-plugin/src/rules/no-inferrable-types.ts

Lines 73 to 80 in a54a60b

function isIdentifier(
init: TSESTree.Expression,
...names: string[]
): boolean {
return (
init.type === AST_NODE_TYPES.Identifier && names.includes(init.name)
);
}

It might be a nice good first issue PR 😄

Metadata

Metadata

Assignees

No one assigned

    Labels

    locked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.repo maintenancethings to do with maintenance of the repo, and not with code/docswontfixThis will not be worked on

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions