Skip to content

Bug: [no-misused-promises] Fails to check unions that contain misused promises. #8494

Closed
@kirkwaiblinger

Description

@kirkwaiblinger

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=4.8.4&showAST=es&fileType=.tsx&code=CYUwxgNghgTiAEAzArgOzAFwJYHtXyjDBAAcMBnANRy2AGEoIIAjQgawAoA3G%2Bxl9gC54aUIiyoQweAB94HDgEp4AXgB88HrUWKA3AFgAUKEiwEYPOQzwAtlACezEAAUYOG1nIgGTVmDbCoiDiktJyCsrq8K7uniAAPFrAaopGhMRkVLw%2BAv4cdo4ubh5eOX5sekA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Jge1oFtLlZkiACa1i0Dr0GoMkRNHHRI4MAF8QKoA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

declare function acceptsVoidCallback(voidCallback: undefined | (() => void));
declare const maybePromiseCallback: undefined | (() => Promise<void>)
acceptsVoidCallback(maybePromiseCallback);

ESLint Config

module.exports = {
  "rules": {
    "@typescript-eslint/no-misused-promises": "error"
  }
}

tsconfig

{
  "compilerOptions": {
    "strictNullChecks": true
  }
}

Expected Result

I expect that the 3rd line should report "Promise returned in function argument where a void return was expected"

Actual Result

There was no error on the 3rd line.

Additional Info

This continues the conversation from #5744 (comment).

The rule does already check arguments that have multiple call signatures, but it doesn't check whether it is a union of something that has call signatures and something that doesn't.

We should also try to ensure that complex test cases around (possibly multiple) spread args behave appropriately, including yucky things like

declare function acceptsVoidCallbacks(...voidCallbacks: Array<undefined | (() => void)>);
declare const maybePromiseCallback: undefined | (() => Promise<void>)
declare const voidCallback: () => void;
acceptsVoidCallbacks(voidCallback, undefined, ...[voidCallback, voidCallback], ...[maybePromiseCallback], ...[voidCallback]);

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuebugSomething isn't workinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions