-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
@typescript-eslint/no-useless-constructor won't turn off. #873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Could you post your eslint config as well? Chances are you're using a config set which uses I also notice you're using v1.6 of our tooling, why are you on such an old version? You should upgrade as you're missing a large number of bug fixes and performance improvements. |
This was all created roughly a month ago with create-react-app and Storybook. The version of 1.6.0 in the tooling is what I see for the version value in the package.json under node_modules@typescript-eslint that create-react-app installed. I didn't install these modules manually, create-react-app installed them automatically. A fresh test of create-react-app appears to install version 1.13.0. Looking through the files after your input, I am not sure why I have an .eslintrc file as all files are TypeScript and am using TSLint. I've deleted my .eslintrc file and removed Here is the .eslintrc anyways though as requested:
Current tslint.json file
|
This is the config: https://github.com/facebook/create-react-app/blob/master/packages/eslint-config-react-app/index.js Note that, as expected, it uses an You will have to use a similar overrides block in your config because you're using eslint v5. |
Uh oh!
There was an error while loading. Please reload this page.
What code were you trying to parse?
with .eslintrc.js
and tslint.json
along with every value combinations off
"off"
,false
, and0
.Documentation followed at:
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-useless-constructor.md
What did you expect to happen?
Expect to receive no warnings for useless constructors.
What actually happened?
Compiled with warnings.
Versions
@typescript-eslint/eslint-plugin-tslint
1.6.0
@typescript-eslint/parser
1.6.0
TypeScript
3.5.2
ESLint
5.16.0
node
10.16.0
npm
6.9.0
The text was updated successfully, but these errors were encountered: