Skip to content

Enhancement: Remove AST properties deprecated in v6 #8927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
JoshuaKGoldberg opened this issue Apr 15, 2024 · 1 comment · Fixed by #8933
Closed
4 tasks done

Enhancement: Remove AST properties deprecated in v6 #8927

JoshuaKGoldberg opened this issue Apr 15, 2024 · 1 comment · Fixed by #8933
Labels
accepting prs Go ahead, send a pull request that resolves this issue breaking change This change will require a new major version to be released enhancement New feature or request locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: ast-spec Issues related to @typescript-eslint/ast-spec
Milestone
8.0.0

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Apr 15, 2024 •
edited
Loading

Before You File a Proposal Please Confirm You Have Done The Following...

Relevant Package

ast-spec

My proposal is suitable for this project

  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Description

#6274 added renamed several AST properties and marked the old names as @deprecated. It'd be a major breaking change to remove them.

Let's do that for v8!

For example:

typescript-eslint/packages/ast-spec/src/base/ClassBase.ts

Lines 56 to 59 in df131e2

/** @deprecated Use {@link `superTypeArguments`} instead. */
superTypeParameters: TSTypeParameterInstantiation | undefined;

Additional Info

We'll want to update the FAQ mention of these too.

typescript-eslint/docs/troubleshooting/FAQ.mdx

Line 470 in 7c77b1b

## "The '`<key>`' property is deprecated on '`<type>`' nodes. Use '`<key>`' instead." warnings

💖
@JoshuaKGoldberg JoshuaKGoldberg added enhancement New feature or request breaking change This change will require a new major version to be released accepting prs Go ahead, send a pull request that resolves this issue labels Apr 15, 2024
@JoshuaKGoldberg JoshuaKGoldberg added this to the 8.0.0 milestone Apr 15, 2024
@JoshuaKGoldberg JoshuaKGoldberg added the package: ast-spec Issues related to @typescript-eslint/ast-spec label Apr 15, 2024
@abrahamguo abrahamguo mentioned this issue Apr 15, 2024
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg changed the title Enhancement: Remove AST properties deprecated in v8 Enhancement: Remove AST properties deprecated in v6 Apr 25, 2024
@JoshuaKGoldberg
Copy link
Member Author

#8933 was merged into the v8 branch. Hooray!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2024
@bradzacher bradzacher added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Apr 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue breaking change This change will require a new major version to be released enhancement New feature or request locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: ast-spec Issues related to @typescript-eslint/ast-spec
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

feat(ast-spec): remove deprecated type params abrahamguo/typescript-eslint
2 participants
@JoshuaKGoldberg @bradzacher