-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
eslint-plugin: Back-port new rules around empty object types from v8 #9437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Leave this to me! |
@Vinccool96 your enthusiasm is noted and appreciated 😄 thanks! But, we generally try to avoid "cookie licking" in the issue tracker: https://typescript-eslint.io/contributing/issues#issue-claiming. Sometimes folks will claim an issue and then drop out, leaving it hanging ("licked"). |
Is it normal that, in the v8 version of the rule, this doesn't create an error? interface Base {
name: string;
}
interface Derived {
age: number;
}
// valid because extending multiple interfaces can be used instead of a union type
interface Both extends Base, Derived {} I know it says in the comment |
That would be a separate discussion or issue from this one 🙂. Off the top of my head I don't remember, and it would be good to have that as a standalone discoverable discussion/issue. |
How do I make the playground use v8 for the issue? |
Overview
Back in #8977 on the
v8
branch
, we'd deprecatedban-types
+no-empty-interfaces
and split functionality into a newno-empty-object-type
rule. Yay!Coming over from #8977 (comment): there's no reason why we couldn't also add that rule in v7 too. We can leave it out of recommended rulesets for now, and just have it available if users want to use it in the meantime.
💖
The text was updated successfully, but these errors were encountered: