Skip to content

Configs: Add no-unnecessary-type-parameters to strict-type-checked preset #9438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
JoshuaKGoldberg opened this issue Jun 26, 2024 · 2 comments
Closed
2 tasks done

Configs: Add no-unnecessary-type-parameters to strict-type-checked preset #9438

JoshuaKGoldberg opened this issue Jun 26, 2024 · 2 comments
Assignees
@JoshuaKGoldberg
Labels
locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin preset config change Proposal for an addition, removal, or general change to a preset config team assigned A member of the typescript-eslint team should work on this.

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Jun 26, 2024 •
edited
Loading

Before You File a Proposal Please Confirm You Have Done The Following...

Description

Following #8173: I opted to keep the @typescript-eslint/no-unnecessary-type-parameters out of the strict-type-checked preset because we wanted to give it a "warning: early stage and experimental" notice. We're trying the rule on this codebase for now and hope some enterprising users might pick it up. But until it's added to strict-type-checked, we're not likely to get a lot of user testing.

Filing this issue as a followup to track adding the rule to strict-type-checked and removing its warning notice.

💖

Impacted Configurations

strict-type-checked

Additional Info

cc @danvk as a heads up 🙂
@JoshuaKGoldberg JoshuaKGoldberg added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin blocked by another issue Issues which are not ready because another issue needs to be resolved first preset config change Proposal for an addition, removal, or general change to a preset config labels Jun 26, 2024
@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed blocked by another issue Issues which are not ready because another issue needs to be resolved first labels Jul 29, 2024
@JoshuaKGoldberg
Copy link
Member Author

The rule has worked well for us in the v8 branch. Per discussion with @kirkwaiblinger internally, we'd like to get this in for v8. 🚀

@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jul 29, 2024
@JoshuaKGoldberg JoshuaKGoldberg added team assigned A member of the typescript-eslint team should work on this. and removed accepting prs Go ahead, send a pull request that resolves this issue labels Jul 29, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jul 29, 2024
Merged
3 tasks
@github-actions GitHub Actions
Copy link

Closed by #9662.

@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Aug 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin preset config change Proposal for an addition, removal, or general change to a preset config team assigned A member of the typescript-eslint team should work on this.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoshuaKGoldberg