Hmmm, fun. Are never-returning functions treated as error-typed?

Hi @CreativeTechGuy!

Does this repro for you locally or just in the playground? We've had some trouble with types in the playground lately, for example see #9594 and #8696

I believe this error was introduced in #9304

As also discussed in #9591, #9304 made no changes to whether or not the rule reports - it just changes whether the error messages say "Unsafe call of an error-typed value", instead of "Unsafe call of an any-typed value"

Yes this repos locally which is how I found it when updating dependencies. So it's not just the playground @kirkwaiblinger

@Josh-Cena Looks like no; this doesn't flag....

function neverTypedFunction(): never {
  throw new Error();
}

neverTypedFunction(); 

@CreativeTechGuy
Gotcha, thanks for the info! My guess is that it has something funky to do with how the types are configured in the tsconfig, but some investigation will be needed it seems.

I don't know the exact version this was introduced. But I can confirm that 7.14.1 was working. So something between 7.15.0-7.16.1 changed.

Just dropping one further breadcrumb for investigation, other functions on process that TS is ok with also run into this report, e.g.

process.getActiveResourcesInfo()

as well as other imported node types

import { relative } from "node:path";
relative("foo", "bar");

Could someone post a standalone reproduction that isn't the playground please? We'll want to investigate this locally.

This is likely a local setup issue yeah. Need a repro to investigate further.

I'll work on a repro early next week. Thank you for looking into this!

It looks like it was a configuration issue. I had a global type augmentation for process so I could set the type of process.env in browser/bundler environments, and that was getting applied more broadly than I intended.

So I concede that it was user error and can be fixed. The error message was very confusing and for some reason didn't show up until I updated dependencies. Although I'm having a hard time finding a minimal reproduction.

Could the message "Unsafe call of an `error` type typed value" be renamed to something like "Unsafe call of an untyped value" or something like that? Something to indicate that it's an error because TS ESLint doesn't see it's type even though your editor/typescript does. That'd be helpful and point people in the direction of it being a configuration error with typescript configured differently than eslint.

@CreativeTechGuy

Thanks for following up!

Could the message be renamed?

Let's use #9591 for that discussion.

Cheers 🙂