Skip to content

Enhancement: [no-unnecessary-type-parameters] Add suggestions for simple cases. #9663

Closed
@kirkwaiblinger

Description

@kirkwaiblinger

Before You File a Proposal Please Confirm You Have Done The Following...

My proposal is suitable for this project

  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Link to the rule's documentation

https://typescript-eslint.io/rules/no-unnecessary-type-parameters/

Description

Add suggestions with the intended fix.

Fail

function toUnknown<T>(x: T): unknown {
    return x;
}

function withExtends<T extends number | string>(x: T): unknown {
    return Math.random();
}

Pass

// replace unconstrained input generic with unknown
function toUnknown(x: unknown): unknown {
   return x;
}

// replace constrained input generic with its constraint type
function withExtends(x: number | string): unknown {
    return Math.random();
}

Additional Info

There are probably more cases where we could make suggestions, too. These are just the first things that came to mind. I think that adding these suggestions would have high value to help the user understood why the rule is reporting, since this rule is quite subtle

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issueenhancement: plugin rule optionNew rule option for an existing eslint-plugin rulelocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions