diff --git a/eslint.config.mjs b/eslint.config.mjs index 8e2b821f54ed..1caf0d39663e 100644 --- a/eslint.config.mjs +++ b/eslint.config.mjs @@ -108,11 +108,6 @@ export default tseslint.config( // // our plugin :D // - - '@typescript-eslint/no-confusing-void-expression': [ - 'error', - { ignoreVoidReturningFunctions: true }, - ], '@typescript-eslint/ban-ts-comment': [ 'error', { @@ -123,6 +118,10 @@ export default tseslint.config( 'ts-nocheck': true, }, ], + '@typescript-eslint/no-confusing-void-expression': [ + 'error', + { ignoreVoidReturningFunctions: true }, + ], // TODO: enable it once we drop support for TS<5.0 // https://github.com/typescript-eslint/typescript-eslint/issues/10065 '@typescript-eslint/consistent-type-exports': [ diff --git a/packages/eslint-plugin/docs/rules/no-confusing-void-expression.mdx b/packages/eslint-plugin/docs/rules/no-confusing-void-expression.mdx index a66f94085403..7f1c1c95f971 100644 --- a/packages/eslint-plugin/docs/rules/no-confusing-void-expression.mdx +++ b/packages/eslint-plugin/docs/rules/no-confusing-void-expression.mdx @@ -125,6 +125,8 @@ console.log(void alert('Hello, world!')); ### `ignoreVoidReturningFunctions` +{/* insert option description */} + Whether to ignore returns from functions with `void` return types when inside a function with a `void` return type. Some projects prefer allowing functions that explicitly return `void` to return `void` expressions. Doing so allows more writing more succinct functions. diff --git a/packages/eslint-plugin/tests/docs.test.ts b/packages/eslint-plugin/tests/docs.test.ts index f2add45161cb..b0aefac46144 100644 --- a/packages/eslint-plugin/tests/docs.test.ts +++ b/packages/eslint-plugin/tests/docs.test.ts @@ -253,7 +253,7 @@ describe('Validating rule docs', () => { const headings = tokens.filter(tokenIsH2); headings.forEach(heading => { - const nonCodeText = heading.text.replace(/`[^`]*`/g, ''); + const nonCodeText = heading.text.replaceAll(/`[^`]*`/g, ''); expect(nonCodeText).toBe(titleCase(nonCodeText)); }); });