Skip to content

feat(eslint-plugin): [no-unnecessary-boolean-literal-compare] enforce strictNullChecks #10712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2025
Merged

feat(eslint-plugin): [no-unnecessary-boolean-literal-compare] enforce strictNullChecks #10712

merged 2 commits into from
Feb 3, 2025

Conversation

yeonjuan
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jan 25, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit c1ff73f
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67952663bc885a0008aaebf8
😎 Deploy Preview https://deploy-preview-10712--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 25, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit c1ff73f.

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 7m 24s View ↗
nx test eslint-plugin ✅ Succeeded 6m 1s View ↗
nx test visitor-keys --coverage=false ✅ Succeeded <1s View ↗
nx test type-utils --coverage=false ✅ Succeeded <1s View ↗
nx run types:build ✅ Succeeded <1s View ↗
nx test utils --coverage=false ✅ Succeeded <1s View ↗
nx test typescript-eslint --coverage=false ✅ Succeeded 8s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 30s View ↗
Additional runs (24) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-01-25 18:14:25 UTC

@codecov Codecov
Copy link

codecov bot commented Jan 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.19%. Comparing base (9e8828b) to head (c1ff73f).
Report is 27 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10712   +/-   ##
=======================================
  Coverage   87.19%   87.19%           
=======================================
  Files         450      450           
  Lines       15632    15637    +5     
  Branches     4570     4572    +2     
=======================================
+ Hits        13630    13635    +5     
  Misses       1645     1645           
  Partials      357      357
Flag Coverage Δ
unittest 87.19% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/rules/no-unnecessary-boolean-literal-compare.ts 97.70% <100.00%> (+0.14%) ⬆️

... and 2 files with indirect coverage changes

@yeonjuan yeonjuan marked this pull request as ready for review January 26, 2025 04:25
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 perfection. Thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 06925f8 into typescript-eslint:main Feb 3, 2025
62 checks passed
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 5, 2025
@renovate
Update typescript-eslint monorepo to v8.23.0
4b0a3a7 
| datasource | package                          | from   | to     |
| ---------- | -------------------------------- | ------ | ------ |
| npm        | @typescript-eslint/eslint-plugin | 8.22.0 | 8.23.0 |
| npm        | @typescript-eslint/parser        | 8.22.0 | 8.23.0 |


## [v8.23.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8230-2025-02-03)

##### 🚀 Features

-   **eslint-plugin:** \[no-unnecessary-boolean-literal-compare] enforce strictNullChecks ([#10712](typescript-eslint/typescript-eslint#10712))

##### 🩹 Fixes

-   **eslint-plugin:** \[no-shadow] ignore declare variables in definition files shadowing global variables ([#10710](typescript-eslint/typescript-eslint#10710))
-   **eslint-plugin:** \[no-restricted-imports] support regex option ([#10699](typescript-eslint/typescript-eslint#10699))
-   **eslint-plugin:** \[dot-notation] handle noPropertyAccessFromIndexSignature true ([#10644](typescript-eslint/typescript-eslint#10644))
-   **eslint-plugin:** \[prefer-nullish-coalescing] fix missing return ([#10732](typescript-eslint/typescript-eslint#10732))
-   bump ts-api-utils to ^2.0.1 ([#10761](typescript-eslint/typescript-eslint#10761))
-   **eslint-plugin:** \[no-unnecessary-template-expression] allow interpolating type parameter in type context ([#10739](typescript-eslint/typescript-eslint#10739))
-   **eslint-plugin:** \[switch-exhaustiveness-check] suggest with qualified name ([#10697](typescript-eslint/typescript-eslint#10697))
-   **eslint-plugin:** \[no-unnecessary-type-assertion] should report readonly class properties with a literal initializer ([#10618](typescript-eslint/typescript-eslint#10618))

##### ❤️ Thank You

-   Josh Goldberg ✨
-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)
-   Ryan Poon [@sopa301](https://github.com/sopa301)
-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)
-   Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 5, 2025
@renovate
Update typescript-eslint monorepo to v8.23.0
2affa96 
| datasource | package                          | from   | to     |
| ---------- | -------------------------------- | ------ | ------ |
| npm        | @typescript-eslint/eslint-plugin | 8.22.0 | 8.23.0 |
| npm        | @typescript-eslint/parser        | 8.22.0 | 8.23.0 |


## [v8.23.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8230-2025-02-03)

##### 🚀 Features

-   **eslint-plugin:** \[no-unnecessary-boolean-literal-compare] enforce strictNullChecks ([#10712](typescript-eslint/typescript-eslint#10712))

##### 🩹 Fixes

-   **eslint-plugin:** \[no-shadow] ignore declare variables in definition files shadowing global variables ([#10710](typescript-eslint/typescript-eslint#10710))
-   **eslint-plugin:** \[no-restricted-imports] support regex option ([#10699](typescript-eslint/typescript-eslint#10699))
-   **eslint-plugin:** \[dot-notation] handle noPropertyAccessFromIndexSignature true ([#10644](typescript-eslint/typescript-eslint#10644))
-   **eslint-plugin:** \[prefer-nullish-coalescing] fix missing return ([#10732](typescript-eslint/typescript-eslint#10732))
-   bump ts-api-utils to ^2.0.1 ([#10761](typescript-eslint/typescript-eslint#10761))
-   **eslint-plugin:** \[no-unnecessary-template-expression] allow interpolating type parameter in type context ([#10739](typescript-eslint/typescript-eslint#10739))
-   **eslint-plugin:** \[switch-exhaustiveness-check] suggest with qualified name ([#10697](typescript-eslint/typescript-eslint#10697))
-   **eslint-plugin:** \[no-unnecessary-type-assertion] should report readonly class properties with a literal initializer ([#10618](typescript-eslint/typescript-eslint#10618))

##### ❤️ Thank You

-   Josh Goldberg ✨
-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)
-   Ryan Poon [@sopa301](https://github.com/sopa301)
-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)
-   Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-unnecessary-boolean-literal-compare] should require strictNullChecks
2 participants
@yeonjuan @JoshuaKGoldberg