fix(eslint-plugin): [prefer-nullish-coalescing] fix missing return #10732

OlivierZal · 2025-01-28T16:06:16Z

PR Checklist

Addresses an existing open issue: fixes Bug: [prefer-nullish-coalescing] Should not report error #10724
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

typescript-eslint · 2025-01-28T16:06:19Z

Thanks for the PR, @OlivierZal!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2025-01-28T16:06:57Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`2d267d8`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6799125b6b1dd0000801da96
😎 Deploy Preview	https://deploy-preview-10732--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 94 (🔴 down 4 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

nx-cloud · 2025-01-28T16:07:12Z

View your CI Pipeline Execution ↗ for commit 2d267d8.

Command	Status	Duration	Result
`nx run-many --target=build --exclude website --...`	✅ Succeeded	1s	View ↗
`nx run-many --target=clean`	✅ Succeeded	10s	View ↗

☁️ Nx Cloud last updated this comment at 2025-01-28 17:38:34 UTC

OlivierZal · 2025-01-28T16:07:21Z

@kirkwaiblinger, tests pass locally.

codecov · 2025-01-28T16:27:05Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.26%. Comparing base (94e8098) to head (2d267d8).
Report is 11 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #10732   +/-   ##
=======================================
  Coverage   87.26%   87.26%           
=======================================
  Files         450      450           
  Lines       15712    15713    +1     
  Branches     4600     4600           
=======================================
+ Hits        13711    13712    +1     
  Misses       1645     1645           
  Partials      356      356

Flag	Coverage Δ
unittest	`87.26% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...lint-plugin/src/rules/prefer-nullish-coalescing.ts	`96.00% <100.00%> (+0.02%)`	⬆️

kirkwaiblinger

Thanks for the quick turnaround on this! Looks good to me! 🙂

packages/eslint-plugin/tests/rules/prefer-nullish-coalescing.test.ts

OlivierZal · 2025-01-28T20:14:48Z

Self-reminder: rebase #10708 once merged.

@OlivierZal

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.22.0 | 8.23.0 | | npm | @typescript-eslint/parser | 8.22.0 | 8.23.0 | ## [v8.23.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8230-2025-02-03) ##### 🚀 Features - **eslint-plugin:** \[no-unnecessary-boolean-literal-compare] enforce strictNullChecks ([#10712](typescript-eslint/typescript-eslint#10712)) ##### 🩹 Fixes - **eslint-plugin:** \[no-shadow] ignore declare variables in definition files shadowing global variables ([#10710](typescript-eslint/typescript-eslint#10710)) - **eslint-plugin:** \[no-restricted-imports] support regex option ([#10699](typescript-eslint/typescript-eslint#10699)) - **eslint-plugin:** \[dot-notation] handle noPropertyAccessFromIndexSignature true ([#10644](typescript-eslint/typescript-eslint#10644)) - **eslint-plugin:** \[prefer-nullish-coalescing] fix missing return ([#10732](typescript-eslint/typescript-eslint#10732)) - bump ts-api-utils to ^2.0.1 ([#10761](typescript-eslint/typescript-eslint#10761)) - **eslint-plugin:** \[no-unnecessary-template-expression] allow interpolating type parameter in type context ([#10739](typescript-eslint/typescript-eslint#10739)) - **eslint-plugin:** \[switch-exhaustiveness-check] suggest with qualified name ([#10697](typescript-eslint/typescript-eslint#10697)) - **eslint-plugin:** \[no-unnecessary-type-assertion] should report readonly class properties with a literal initializer ([#10618](typescript-eslint/typescript-eslint#10618)) ##### ❤️ Thank You - Josh Goldberg ✨ - Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal) - Ryan Poon [@sopa301](https://github.com/sopa301) - YeonJuan [@yeonjuan](https://github.com/yeonjuan) - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

@OlivierZal

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.22.0 | 8.23.0 | | npm | @typescript-eslint/parser | 8.22.0 | 8.23.0 | ## [v8.23.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8230-2025-02-03) ##### 🚀 Features - **eslint-plugin:** \[no-unnecessary-boolean-literal-compare] enforce strictNullChecks ([#10712](typescript-eslint/typescript-eslint#10712)) ##### 🩹 Fixes - **eslint-plugin:** \[no-shadow] ignore declare variables in definition files shadowing global variables ([#10710](typescript-eslint/typescript-eslint#10710)) - **eslint-plugin:** \[no-restricted-imports] support regex option ([#10699](typescript-eslint/typescript-eslint#10699)) - **eslint-plugin:** \[dot-notation] handle noPropertyAccessFromIndexSignature true ([#10644](typescript-eslint/typescript-eslint#10644)) - **eslint-plugin:** \[prefer-nullish-coalescing] fix missing return ([#10732](typescript-eslint/typescript-eslint#10732)) - bump ts-api-utils to ^2.0.1 ([#10761](typescript-eslint/typescript-eslint#10761)) - **eslint-plugin:** \[no-unnecessary-template-expression] allow interpolating type parameter in type context ([#10739](typescript-eslint/typescript-eslint#10739)) - **eslint-plugin:** \[switch-exhaustiveness-check] suggest with qualified name ([#10697](typescript-eslint/typescript-eslint#10697)) - **eslint-plugin:** \[no-unnecessary-type-assertion] should report readonly class properties with a literal initializer ([#10618](typescript-eslint/typescript-eslint#10618)) ##### ❤️ Thank You - Josh Goldberg ✨ - Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal) - Ryan Poon [@sopa301](https://github.com/sopa301) - YeonJuan [@yeonjuan](https://github.com/yeonjuan) - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

fix(eslint-plugin): [prefer-nullish-coalescing] fix missing return

28d8cd7

OlivierZal mentioned this pull request Jan 28, 2025

Bug: [prefer-nullish-coalescing] Should not report error #10724

Closed

4 tasks

kirkwaiblinger previously approved these changes Jan 28, 2025

View reviewed changes

packages/eslint-plugin/tests/rules/prefer-nullish-coalescing.test.ts Show resolved Hide resolved

kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jan 28, 2025

kirkwaiblinger mentioned this pull request Jan 28, 2025

Bug: [prefer-nullish-coalescing] has various bugs around multi-part nullishness checks #10733

Closed

4 tasks

OlivierZal dismissed kirkwaiblinger’s stale review via c94934e January 28, 2025 17:19

OlivierZal requested a review from kirkwaiblinger January 28, 2025 17:20

github-actions bot removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jan 28, 2025

add tests

2d267d8

OlivierZal force-pushed the prefer-nullish-coalescing-10724 branch from a23e684 to 2d267d8 Compare January 28, 2025 17:22

kirkwaiblinger approved these changes Jan 28, 2025

View reviewed changes

kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jan 28, 2025

OlivierZal mentioned this pull request Jan 28, 2025

fix(eslint-plugin): [prefer-nullish-coalescing] report on chain expressions in a ternary #10708

Merged

3 tasks

JoshuaKGoldberg merged commit 82cb00d into typescript-eslint:main Feb 3, 2025
64 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(eslint-plugin): [prefer-nullish-coalescing] fix missing return #10732

fix(eslint-plugin): [prefer-nullish-coalescing] fix missing return #10732

OlivierZal commented Jan 28, 2025 •

edited

Loading

typescript-eslint bot commented Jan 28, 2025

netlify bot commented Jan 28, 2025 •

edited

Loading

nx-cloud bot commented Jan 28, 2025 •

edited

Loading

OlivierZal commented Jan 28, 2025

codecov bot commented Jan 28, 2025 •

edited

Loading

kirkwaiblinger left a comment

OlivierZal commented Jan 28, 2025

fix(eslint-plugin): [prefer-nullish-coalescing] fix missing return #10732

fix(eslint-plugin): [prefer-nullish-coalescing] fix missing return #10732

Conversation

OlivierZal commented Jan 28, 2025 • edited Loading

PR Checklist

Overview

typescript-eslint bot commented Jan 28, 2025

netlify bot commented Jan 28, 2025 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

nx-cloud bot commented Jan 28, 2025 • edited Loading

OlivierZal commented Jan 28, 2025

codecov bot commented Jan 28, 2025 • edited Loading

Codecov Report

kirkwaiblinger left a comment

Choose a reason for hiding this comment

OlivierZal commented Jan 28, 2025

OlivierZal commented Jan 28, 2025 •

edited

Loading

netlify bot commented Jan 28, 2025 •

edited

Loading

nx-cloud bot commented Jan 28, 2025 •

edited

Loading

codecov bot commented Jan 28, 2025 •

edited

Loading