Skip to content

chore(eslint-plugin-internal): migrate from jest to vitest #10771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Mar 17, 2025
Merged

chore(eslint-plugin-internal): migrate from jest to vitest #10771

merged 25 commits into from
Mar 17, 2025

Conversation

aryaemami59
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Feb 4, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit c607191
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67d6b033b2fa7700083bf66b
😎 Deploy Preview https://deploy-preview-10771--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 4, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit c607191.

Command Status Duration Result
nx test eslint-plugin ✅ Succeeded 6m 13s View ↗
nx run eslint-plugin:test -- --coverage ✅ Succeeded 6m 10s View ↗
nx run integration-tests:test ✅ Succeeded 2m 22s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 6m 23s View ↗
nx test typescript-estree ✅ Succeeded 1m 2s View ↗
nx test type-utils ✅ Succeeded 20s View ↗
nx run types:build ✅ Succeeded <1s View ↗
nx test typescript-eslint ✅ Succeeded 5s View ↗
Additional runs (25) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-03-16 11:20:52 UTC

@codecov Codecov
Copy link

codecov bot commented Feb 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.97%. Comparing base (543d36c) to head (c607191).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10771      +/-   ##
==========================================
+ Coverage   87.58%   87.97%   +0.38%     
==========================================
  Files         470      470              
  Lines       16095    16709     +614     
  Branches     4668     4710      +42     
==========================================
+ Hits        14097    14699     +602     
- Misses       1642     1664      +22     
+ Partials      356      346      -10
Flag Coverage Δ
unittest 87.97% <ø> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aryaemami59 aryaemami59 force-pushed the chore/eslint-plugin-internal-vitest-migration branch 19 times, most recently from 2bd4f9c to 4516a9a Compare February 10, 2025 17:38
@aryaemami59 aryaemami59 force-pushed the chore/eslint-plugin-internal-vitest-migration branch 6 times, most recently from 355c47b to fff2a83 Compare February 15, 2025 12:06
@JoshuaKGoldberg
Copy link
Member

Marking as blocked on #10582. We'd like to normalize test scripts & coverage calculations before making the jump in individual packages.

kirkwaiblinger
kirkwaiblinger previously approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is in good shape! Thanks for spending so much time and attention to detail on these! 🙏

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Mar 14, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elderly gentleman happily saying "HELL YEAH!"

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Mar 14, 2025
@github-actions github-actions bot removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Mar 15, 2025
@aryaemami59 aryaemami59 force-pushed the chore/eslint-plugin-internal-vitest-migration branch from 85affb3 to c7c3f40 Compare March 16, 2025 02:25
@aryaemami59 aryaemami59 force-pushed the chore/eslint-plugin-internal-vitest-migration branch from 7a4fc31 to c607191 Compare March 16, 2025 11:04
@JoshuaKGoldberg
Copy link
Member

Merging now. Let's hope nothing breaks! 😄 🤞

@JoshuaKGoldberg JoshuaKGoldberg merged commit 2b4f05c into typescript-eslint:main Mar 17, 2025
59 checks passed
@kirkwaiblinger kirkwaiblinger mentioned this pull request Mar 22, 2025
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2025
@aryaemami59 aryaemami59 deleted the chore/eslint-plugin-internal-vitest-migration branch March 26, 2025 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg Awaiting requested review from JoshuaKGoldberg

@kirkwaiblinger kirkwaiblinger Awaiting requested review from kirkwaiblinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aryaemami59 @JoshuaKGoldberg @kirkwaiblinger