Skip to content

chore(typescript-eslint): migrate from jest to vitest #10772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Mar 24, 2025
Merged

chore(typescript-eslint): migrate from jest to vitest #10772

merged 23 commits into from
Mar 24, 2025

Conversation

aryaemami59
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Feb 4, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit f1e0834
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67de0bf8d0b07800083166aa
😎 Deploy Preview https://deploy-preview-10772--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 92 (🔴 down 7 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 4, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit f1e0834.

Command Status Duration Result
nx run integration-tests:test ❌ Failed 2m 20s View ↗
nx test eslint-plugin ✅ Succeeded 7m 35s View ↗
nx test typescript-estree ✅ Succeeded 1m 13s View ↗
nx run utils:test -- --coverage ✅ Succeeded 5s View ↗
nx run types:build ✅ Succeeded <1s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 52s View ↗
nx test scope-manager ✅ Succeeded 15s View ↗
nx test utils ✅ Succeeded 8s View ↗
Additional runs (25) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-03-22 01:29:05 UTC

@codecov Codecov
Copy link

codecov bot commented Feb 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.98%. Comparing base (8474474) to head (f1e0834).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10772      +/-   ##
==========================================
+ Coverage   87.97%   87.98%   +0.01%     
==========================================
  Files         470      470              
  Lines       16709    16735      +26     
  Branches     4710     4716       +6     
==========================================
+ Hits        14699    14725      +26     
  Misses       1664     1664              
  Partials      346      346
Flag Coverage Δ
unittest 87.98% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aryaemami59 aryaemami59 force-pushed the chore/typescript-eslint-vitest-migration branch 18 times, most recently from 0cce14d to c725c24 Compare February 10, 2025 17:50
@aryaemami59 aryaemami59 force-pushed the chore/typescript-eslint-vitest-migration branch 6 times, most recently from b8c067a to 5c93e1a Compare February 15, 2025 12:18
@JoshuaKGoldberg
Copy link
Member

Marking as blocked on #10582. We'd like to normalize test scripts & coverage calculations before making the jump in individual packages.

@JoshuaKGoldberg JoshuaKGoldberg added the blocked by another PR PRs which are ready to go but waiting on another PR label Feb 25, 2025
@aryaemami59 aryaemami59 force-pushed the chore/typescript-eslint-vitest-migration branch from 272bcbe to c5e83a5 Compare March 4, 2025 06:04
aryaemami59 added 19 commits March 7, 2025 07:51
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
691a3ca 
…t-eslint into chore/typescript-eslint-vitest-migration
@aryaemami59
Update vitest to version 3.0.8
3609bed
@aryaemami59
Remove vitest/no-done-callback as it is deprecated.
65238e0
@aryaemami59
Fix Vitest config
1ed63ff
@aryaemami59
Include vitest.config.mts in tsconfig.spec.json
fc07af1
@aryaemami59
Add vitest.config.mts files to ESLint configuration
69caafb
@aryaemami59
Use defineProject instead of defineConfig
ca31d4e
@aryaemami59
Simplify workspace and coverage.exclude
19ebf4b
@aryaemami59
Explicitly enable resolveJsonModule
56b2de3
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
de160a3 
…t-eslint into chore/typescript-eslint-vitest-migration
@aryaemami59
Type check vitest.config.mts files using project references.
bb28ba4
@aryaemami59
Fix @nx/vite/plugin usage in nx.json
04eea20
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
08bb1a8 
…t-eslint into chore/typescript-eslint-vitest-migration
@aryaemami59
Update @vitest/eslint-plugin to version 1.1.37
0e75892
@aryaemami59
Fix Vitest config
61f27d1
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
0bc9868 
…t-eslint into chore/typescript-eslint-vitest-migration
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
ec10987 
…t-eslint into chore/typescript-eslint-vitest-migration
@aryaemami59
Update vite to version 6.2.2
273e62a
@aryaemami59
Fix typecheck task
554e60c
@aryaemami59 aryaemami59 force-pushed the chore/typescript-eslint-vitest-migration branch from a593927 to 554e60c Compare March 16, 2025 12:26
@kirkwaiblinger
Copy link
Member

seems like a straightforward corollary of #10771, with a whole bunch initial boilerplate. Sweet! 🙂

@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Mar 22, 2025
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@JoshuaKGoldberg
Copy link
Member

Integration tests are failing on other PRs too. We can ignore them here.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 649309f into typescript-eslint:main Mar 24, 2025
56 of 58 checks passed
@aryaemami59 aryaemami59 deleted the chore/typescript-eslint-vitest-migration branch March 26, 2025 19:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aryaemami59 @JoshuaKGoldberg @kirkwaiblinger