chore: migrate rule-schema-to-typescript-types from jest to vitest
#10774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @aryaemami59! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
View your CI Pipeline Execution ↗ for commit 49e0121.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10774 +/- ##
=======================================
Coverage 90.82% 90.82%
=======================================
Files 497 497
Lines 50204 50204
Branches 8274 8274
=======================================
Hits 45600 45600
Misses 4589 4589
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
0e06367 to
e1e3271
Compare
jest to vitestrule-schema-to-typescript-types from jest to vitest
ca08b3e to
44b0ac0
Compare
13825b7 to
a3f9d7f
Compare
|
Marking as blocked on #10582. We'd like to normalize test scripts & coverage calculations before making the jump in individual packages. |
dadee50 to
863b922
Compare
…t-eslint into chore/rule-schema-to-typescript-types-vitest-migration
…t-eslint into chore/rule-schema-to-typescript-types-vitest-migration
…t-eslint into chore/rule-schema-to-typescript-types-vitest-migration
…t-eslint into chore/rule-schema-to-typescript-types-vitest-migration
…t-eslint into chore/rule-schema-to-typescript-types-vitest-migration
…t-eslint into chore/rule-schema-to-typescript-types-vitest-migration
…t-eslint into chore/rule-schema-to-typescript-types-vitest-migration
…t-eslint into chore/rule-schema-to-typescript-types-vitest-migration
…t-eslint into chore/rule-schema-to-typescript-types-vitest-migration
14 tasks
JoshuaKGoldberg
approved these changes
Apr 15, 2025
7f32763
into
typescript-eslint:main
50 of 53 checks passed
phaux
pushed a commit
to phaux/typescript-eslint
that referenced
this pull request
Apr 24, 2025
…st` (typescript-eslint#10774) * Install `vitest` * Rename `jest.config.js` to `vitest.config.mts` * chore(rule-schema-to-typescript-types): migrate to `vitest` * Fix Vitest config * Include `vitest.config.mts` in `tsconfig.spec.json` * Explicitly enable `resolveJsonModule` * Use `.replace` instead of `.split` * Type check `vitest.config.mts` files using project references. * Fix Vitest config * Update `vitest` to version 3.1.1 * Update `@vitest/eslint-plugin` to version 1.1.39 * Fix `knip` * Update `vite` to version 6.2.5 * Update `vite` to version 6.2.6 * Update `@vitest/eslint-plugin` to version 1.1.40 * Update `@vitest/eslint-plugin` to version 1.1.42 * Enable the new `vitest/prefer-describe-function-title` rule * Use `vitestPlugin.configs.env` * Try disabling remote cache * Try disabling remote cache * Update `typecheck` output path in `nx.json` * Fix `vitest` coverage output when run with `nx` --------- Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview