Skip to content

chore(utils): migrate from jest to vitest #10777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Apr 11, 2025
Merged

chore(utils): migrate from jest to vitest #10777

merged 36 commits into from
Apr 11, 2025

Conversation

aryaemami59
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Feb 4, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 005e0f2
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67f973bb78e6600008785160
😎 Deploy Preview https://deploy-preview-10777--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (🟢 up 10 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 4, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 005e0f2.

Command Status Duration Result
nx test eslint-plugin ✅ Succeeded 7m 53s View ↗
nx test utils ✅ Succeeded 13s View ↗
nx test rule-tester ✅ Succeeded 10s View ↗
nx test scope-manager ✅ Succeeded 16s View ↗
nx run types:build ✅ Succeeded 1s View ↗
nx test visitor-keys ✅ Succeeded 3s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 1m 11s View ↗
nx test ast-spec ✅ Succeeded 16s View ↗
Additional runs (25) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-04-11 20:21:37 UTC

@codecov Codecov
Copy link

codecov bot commented Feb 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.79%. Comparing base (0f9b55d) to head (005e0f2).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10777      +/-   ##
==========================================
+ Coverage   87.68%   87.79%   +0.11%     
==========================================
  Files         486      459      -27     
  Lines       15910    15679     -231     
  Branches     4602     4578      -24     
==========================================
- Hits        13950    13766     -184     
+ Misses       1615     1569      -46     
+ Partials      345      344       -1
Flag Coverage Δ
unittest 87.79% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aryaemami59 aryaemami59 force-pushed the chore/utils-vitest-migration branch 21 times, most recently from c3c9486 to fa56f66 Compare February 10, 2025 17:53
@aryaemami59 aryaemami59 force-pushed the chore/utils-vitest-migration branch 5 times, most recently from 86b2bfe to e0f0bf5 Compare February 14, 2025 13:59
@aryaemami59 aryaemami59 force-pushed the chore/utils-vitest-migration branch from b466119 to 8f1a911 Compare April 5, 2025 13:17
@aryaemami59 aryaemami59 force-pushed the chore/utils-vitest-migration branch from d4eb056 to 32c8f53 Compare April 7, 2025 21:51
@43081j
Copy link
Contributor

43081j commented Apr 8, 2025

Looks good to me 👍

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Jan 28, 2025
Closed
14 tasks
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rafiki yeeting Simba over the hill in the famous Lion King scene. Caption: "YEET"

@JoshuaKGoldberg JoshuaKGoldberg merged commit af6ace7 into typescript-eslint:main Apr 11, 2025
57 checks passed
@aryaemami59 aryaemami59 deleted the chore/utils-vitest-migration branch April 11, 2025 21:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aryaemami59 @JoshuaKGoldberg @43081j