Skip to content

chore(rule-tester): migrate from jest to vitest #10779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 47 commits into from
Apr 14, 2025
Merged

chore(rule-tester): migrate from jest to vitest #10779

merged 47 commits into from
Apr 14, 2025

Conversation

aryaemami59
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 4, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit fcd36ce.

Command Status Duration Result
nx test eslint-plugin ✅ Succeeded 8m 7s View ↗
nx test typescript-estree ✅ Succeeded 1m 16s View ↗
nx run types:build ✅ Succeeded 1s View ↗
nx test rule-tester ✅ Succeeded 5s View ↗
nx typecheck ast-spec ✅ Succeeded 4s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 1m 7s View ↗
nx test ast-spec ✅ Succeeded 17s View ↗
nx test typescript-eslint ✅ Succeeded 5s View ↗
Additional runs (26) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-04-14 13:33:42 UTC

@netlify Netlify
Copy link

netlify bot commented Feb 4, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit fcd36ce
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67fd09eaf4989d000805b350
😎 Deploy Preview https://deploy-preview-10779--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (🟢 up 10 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Feb 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.44%. Comparing base (f1ceade) to head (fcd36ce).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10779      +/-   ##
==========================================
- Coverage   88.17%   86.44%   -1.73%     
==========================================
  Files         497      497              
  Lines       17840    19056    +1216     
  Branches     4803     4806       +3     
==========================================
+ Hits        15730    16473     +743     
- Misses       1775     2285     +510     
+ Partials      335      298      -37
Flag Coverage Δ
unittest 86.44% <ø> (-1.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aryaemami59 aryaemami59 force-pushed the chore/rule-tester-vitest-migration branch 21 times, most recently from 7122507 to f5d6495 Compare February 10, 2025 17:47
@aryaemami59 aryaemami59 force-pushed the chore/rule-tester-vitest-migration branch 5 times, most recently from ad99a6d to 0ad452e Compare February 14, 2025 13:57
aryaemami59 added 10 commits April 7, 2025 13:23
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
49f8cad 
…t-eslint into chore/rule-tester-vitest-migration
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
555c941 
…t-eslint into chore/rule-tester-vitest-migration
@aryaemami59
Update vite to version 6.2.6
3942c10
@aryaemami59
Update @vitest/eslint-plugin to version 1.1.40
e5d8061
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
918c658 
…t-eslint into chore/rule-tester-vitest-migration
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
47935a7 
…t-eslint into chore/rule-tester-vitest-migration
@aryaemami59
Update @vitest/eslint-plugin to version 1.1.42
2274ba7
@aryaemami59
Enable the new vitest/prefer-describe-function-title rule
85bbc22
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
2c516fe 
…t-eslint into chore/rule-tester-vitest-migration
@aryaemami59
Use vitestPlugin.configs.env
1c0a994
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Jan 28, 2025
Closed
14 tasks
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
138003f 
…t-eslint into chore/rule-tester-vitest-migration
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
b8e70f6 
…t-eslint into chore/rule-tester-vitest-migration
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
bf68c3c 
…t-eslint into chore/rule-tester-vitest-migration
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
7ec9338 
…t-eslint into chore/rule-tester-vitest-migration
@aryaemami59
Run ast-spec:typecheck during postinstall
aafbc86
@aryaemami59
Fix ast-spec:test
f1fddfd
@aryaemami59
Try disabling remote cache
930f64f
@aryaemami59
Try disabling remote cache
99a1e3f
@aryaemami59
Update typecheck output path in nx.json
5ed60b8
@aryaemami59
Fix vitest coverage output when run with nx
cdd1b3c
@aryaemami59
Fix rule-tester tests
5965d19
@aryaemami59 aryaemami59 force-pushed the chore/rule-tester-vitest-migration branch from af3ebc2 to 5965d19 Compare April 12, 2025 09:57
@JoshuaKGoldberg JoshuaKGoldberg merged commit deacba9 into typescript-eslint:main Apr 14, 2025
53 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2025
@aryaemami59 aryaemami59 deleted the chore/rule-tester-vitest-migration branch April 23, 2025 00:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@43081j 43081j 43081j left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aryaemami59 @JoshuaKGoldberg @43081j