Skip to content

fix(eslint-plugin): [no-deprecated] don't report on deprecated accessor property declaration #10813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025
Merged

fix(eslint-plugin): [no-deprecated] don't report on deprecated accessor property declaration #10813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/eslint-plugin/src/rules/no-deprecated.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ export default createRule<Options, MessageIds>({

case AST_NODE_TYPES.MethodDefinition:
case AST_NODE_TYPES.PropertyDefinition:
case AST_NODE_TYPES.AccessorProperty:
return parent.key === node;

case AST_NODE_TYPES.Property:
Expand Down
105 changes: 105 additions & 0 deletions packages/eslint-plugin/tests/rules/no-deprecated.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,14 @@ ruleTester.run('no-deprecated', rule, {

new A().b;
`,
`
class A {
accessor b: 1;
/** @deprecated */ accessor c: 2;
}

new A().b;
`,
`
declare class A {
/** @deprecated */
Expand All @@ -72,6 +80,15 @@ ruleTester.run('no-deprecated', rule, {

A.c;
`,
`
declare class A {
/** @deprecated */
static accessor b: string;
static accessor c: string;
}

A.c;
`,
`
namespace A {
/** @deprecated */
Expand Down Expand Up @@ -2757,5 +2774,93 @@ class B extends A {
},
],
},
{
code: `
declare class A {
/** @deprecated */
accessor b: () => string;
}

declare const a: A;

a.b;
`,
errors: [
{
column: 11,
data: { name: 'b' },
endColumn: 12,
endLine: 9,
line: 9,
messageId: 'deprecated',
},
],
},
{
code: `
declare class A {
/** @deprecated */
accessor b: () => string;
}

declare const a: A;

a.b();
`,
errors: [
{
column: 11,
data: { name: 'b' },
endColumn: 12,
endLine: 9,
line: 9,
messageId: 'deprecated',
},
],
},
{
code: `
class A {
/** @deprecated */
accessor b = (): string => {
return '';
};
}

declare const a: A;

a.b();
`,
errors: [
{
column: 11,
data: { name: 'b' },
endColumn: 12,
endLine: 11,
line: 11,
messageId: 'deprecated',
},
],
},
{
code: `
declare class A {
/** @deprecated */
static accessor b: () => string;
}

A.b();
`,
errors: [
{
column: 11,
data: { name: 'b' },
endColumn: 12,
endLine: 7,
line: 7,
messageId: 'deprecated',
},
],
},
],
});
Loading