Skip to content

chore: fix failing integration tests on deprecation plugin #11002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2025
Merged

chore: fix failing integration tests on deprecation plugin #11002

merged 1 commit into from
Mar 31, 2025

Conversation

KuSh
Copy link
Contributor

@KuSh KuSh commented Mar 27, 2025 •
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

Fix test failures by marking eslint-plugin-deprecation usage as expecting ts failures

Co-authored-by: @aryaemami59

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @KuSh!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 27, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 25f21a1.

Command Status Duration Result
nx run-many --target=build --exclude website --... ✅ Succeeded 3s View ↗
nx run-many --target=clean ✅ Succeeded 11s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-27 19:30:51 UTC

@netlify Netlify
Copy link

netlify bot commented Mar 27, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 25f21a1
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67e5909561abd20008244e3a
😎 Deploy Preview https://deploy-preview-11002--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 92 (🔴 down 7 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@KuSh KuSh changed the title fix(integration-tests): test failures fix: test failures Mar 27, 2025
@KuSh KuSh changed the title fix: test failures fix: integration test failures Mar 27, 2025
@KuSh KuSh changed the title fix: integration test failures fix: integration tests failure Mar 27, 2025
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Mar 31, 2025
Merged
3 tasks
JoshuaKGoldberg
JoshuaKGoldberg reviewed Mar 31, 2025
View reviewed changes
packages/integration-tests/fixtures/flat-config-types-@types__eslint-v8/eslint.config.js
compat.config(deprecationPlugin.configs.recommended),
...compat.config(jestPlugin.configs.recommended),
);
tseslint.config(
// @ts-expect-error
deprecationPlugin.configs.recommended,
// this should error but doesn't because there are no types exported from the jest plugin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - nice to see the plugin has types now 🙂

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the CI cleanup!

I put a co-author attribution in the description because #10999 was sent a few hours earlier than this PR with similar changes. This one is smaller and works so I'll merge this one as-is.

@JoshuaKGoldberg JoshuaKGoldberg changed the title fix: integration tests failure chore: fix failing integration tests on deprecation plugin Mar 31, 2025
@JoshuaKGoldberg JoshuaKGoldberg merged commit 953294d into typescript-eslint:main Mar 31, 2025
72 of 73 checks passed
@KuSh
Copy link
Contributor Author

KuSh commented Mar 31, 2025

LGTM, thanks for the CI cleanup!

I put a co-author attribution in the description because #10999 was sent a few hours earlier than this PR with similar changes. This one is smaller and works so I'll merge this one as-is.

Oh didn't saw that there was another PR. No problem for shared attribution though!

@KuSh KuSh deleted the fix-10992 branch March 31, 2025 13:35
aryaemami59 pushed a commit to aryaemami59/typescript-eslint that referenced this pull request Apr 5, 2025
@KuSh @aryaemami59
chore: fix failing integration tests on deprecation plugin (typescrip…
9d4b7dc 
…t-eslint#11002)

fix: Integration test failures

Fixes typescript-eslint#10992
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Integration test failure on main: flat-config-types-@types__eslint-v8 & -v9
2 participants
@KuSh @JoshuaKGoldberg