Skip to content

fix(eslint-plugin): [consistent-indexed-object-style] check for indirect circular types in aliased mapped types #11177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

fix(eslint-plugin): [consistent-indexed-object-style] check for indirect circular types in aliased mapped types #11177

wants to merge 6 commits into from

Conversation

ronami
Copy link
Member

@ronami ronami commented May 5, 2025

PR Checklist

Overview

This PR addresses #11121 and changes the current circular check for aliased mapped types to use isDeeplyReferencingType which also checks for indirect circular types.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented May 5, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 40956af
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/68192a5de16f1300088b5492
😎 Deploy Preview https://deploy-preview-11177--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 5, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 40956af.

Command Status Duration Result
nx test eslint-plugin ✅ Succeeded 6m 9s View ↗
nx run eslint-plugin:test -- --coverage ✅ Succeeded 6m 29s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 10s View ↗
nx test typescript-eslint ✅ Succeeded 5s View ↗
nx run types:build ✅ Succeeded <1s View ↗
nx test typescript-estree ✅ Succeeded 1s View ↗
nx typecheck ast-spec ✅ Succeeded 2s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 3s View ↗
Additional runs (26) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-05-05 21:27:31 UTC

@codecov Codecov
Copy link

codecov bot commented May 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.91%. Comparing base (d5209cd) to head (40956af).

Files with missing lines Patch % Lines
...lugin/src/rules/consistent-indexed-object-style.ts 77.77% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (77.77%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11177      +/-   ##
==========================================
- Coverage   90.91%   90.91%   -0.01%     
==========================================
  Files         499      499              
  Lines       50809    50813       +4     
  Branches     8369     8370       +1     
==========================================
+ Hits        46195    46197       +2     
- Misses       4599     4601       +2     
  Partials       15       15
Flag Coverage Δ
unittest 90.91% <77.77%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...lugin/src/rules/consistent-indexed-object-style.ts 98.65% <77.77%> (-0.67%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ronami ronami mentioned this pull request May 6, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ronami