fix(eslint-plugin): [explicit-module-boundary-types] fixes #2864 related to functions in nested object properties #3178

grumd · 2021-03-12T16:11:14Z

Gist of it:

explicit-module-boundary-types and explicit-function-return-type both have an option allowTypedFunctionExpressions.
It makes this code correct:

interface ObjectType {
  foo(): number;
}
export const obj: ObjectType = {
  foo: () => 1,
};

The issue is that the following code is not correct even with the option set to true:

interface ObjectType {
  foo: { bar: () => number }; 
}
export const obj: ObjectType = {
  foo: { bar: () => 1 },
};

My PR fixes the issue for both of these rules and adds relevant tests.

My fork can be used with npm/yarn using this, that's what I temporarily will do.

"@typescript-eslint/eslint-plugin": "https://gitpkg.now.sh/grumd/typescript-eslint/packages/eslint-plugin?build",

…dary-types and functions in nested object properties

typescript-eslint · 2021-03-12T16:11:17Z

Thanks for the PR, @grumd!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

armano2

can you add unit tests for explicit-module-boundary-types

grumd · 2021-03-12T17:36:55Z

can you add unit tests for explicit-module-boundary-types

Added

bradzacher

thanks!

fix(eslint-plugin): fixed issue #2864 related to explicit-module-boun…

70f9392

…dary-types and functions in nested object properties

armano2 approved these changes Mar 12, 2021

View reviewed changes

armano2 suggested changes Mar 12, 2021

View reviewed changes

bradzacher added the bug Something isn't working label Mar 12, 2021

fix(eslint-plugin): added tests for explicit-module-boundary-types

9344aa8

grumd requested a review from armano2 March 12, 2021 17:41

bradzacher approved these changes Mar 15, 2021

View reviewed changes

bradzacher merged commit 55e1fba into typescript-eslint:master Mar 15, 2021

Obi-Dann mentioned this pull request Apr 10, 2021

Test Upgrade all dependencies AurorNZ/report-updated-dependencies#7

Draft

github-actions bot mentioned this pull request Apr 12, 2021

Implement GitHub action AurorNZ/report-updated-dependencies#9

Merged

github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(eslint-plugin): [explicit-module-boundary-types] fixes #2864 related to functions in nested object properties #3178

fix(eslint-plugin): [explicit-module-boundary-types] fixes #2864 related to functions in nested object properties #3178

Uh oh!

grumd commented Mar 12, 2021

Uh oh!

typescript-eslint bot commented Mar 12, 2021

Uh oh!

armano2 left a comment •

edited

Loading

Uh oh!

grumd commented Mar 12, 2021

Uh oh!

bradzacher left a comment

Uh oh!

Uh oh!

Uh oh!

fix(eslint-plugin): [explicit-module-boundary-types] fixes #2864 related to functions in nested object properties #3178

fix(eslint-plugin): [explicit-module-boundary-types] fixes #2864 related to functions in nested object properties #3178

Uh oh!

Conversation

grumd commented Mar 12, 2021

Uh oh!

typescript-eslint bot commented Mar 12, 2021

Uh oh!

armano2 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

grumd commented Mar 12, 2021

Uh oh!

bradzacher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

armano2 left a comment •

edited

Loading