From 90b7f39f743cc06d05457937280a50c37a7c9269 Mon Sep 17 00:00:00 2001 From: Rafael Santana Date: Sat, 2 Oct 2021 02:13:21 -0300 Subject: [PATCH] fix(eslint-plugin): [no-restricted-imports] ignore when no options given --- .../eslint-plugin/src/rules/no-restricted-imports.ts | 10 +++++++--- .../tests/rules/no-restricted-imports.test.ts | 1 + 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/packages/eslint-plugin/src/rules/no-restricted-imports.ts b/packages/eslint-plugin/src/rules/no-restricted-imports.ts index 2a01a54c62ec..994b9ddba737 100644 --- a/packages/eslint-plugin/src/rules/no-restricted-imports.ts +++ b/packages/eslint-plugin/src/rules/no-restricted-imports.ts @@ -1,14 +1,14 @@ import { AST_NODE_TYPES } from '@typescript-eslint/experimental-utils'; import baseRule, { - ArrayOfStringOrObjectPatterns, ArrayOfStringOrObject, + ArrayOfStringOrObjectPatterns, } from 'eslint/lib/rules/no-restricted-imports'; import ignore, { Ignore } from 'ignore'; import { - InferOptionsTypeFromRule, - InferMessageIdsTypeFromRule, createRule, deepMerge, + InferMessageIdsTypeFromRule, + InferOptionsTypeFromRule, } from '../util'; export type Options = InferOptionsTypeFromRule; @@ -119,6 +119,10 @@ export default createRule({ const rules = baseRule.create(context); const { options } = context; + if (options.length === 0) { + return {}; + } + const restrictedPaths = getRestrictedPaths(options); const allowedTypeImportPathNameSet: Set = new Set(); for (const restrictedPath of restrictedPaths) { diff --git a/packages/eslint-plugin/tests/rules/no-restricted-imports.test.ts b/packages/eslint-plugin/tests/rules/no-restricted-imports.test.ts index a2c5951a8d14..8f7cb1f88bf4 100644 --- a/packages/eslint-plugin/tests/rules/no-restricted-imports.test.ts +++ b/packages/eslint-plugin/tests/rules/no-restricted-imports.test.ts @@ -8,6 +8,7 @@ const ruleTester = new RuleTester({ ruleTester.run('no-restricted-imports', rule, { valid: [ + "import foo from 'foo';", { code: "import foo from 'foo';", options: ['import1', 'import2'],