Skip to content

fix(eslint-plugin): [consistent-indexed-object-style] do not report for circular references #4347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 27, 2021
Merged

fix(eslint-plugin): [consistent-indexed-object-style] do not report for circular references #4347

merged 2 commits into from
Dec 27, 2021

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Dec 26, 2021 •
edited
Loading

PR Checklist

Overview

cc EvgenyOrekhov/eslint-config-hardcore#356

@armano2 armano2 added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin labels Dec 26, 2021
@armano2 armano2 requested a review from bradzacher December 26, 2021 08:17
@armano2 armano2 self-assigned this Dec 26, 2021
@nx-cloud
Copy link

nx-cloud bot commented Dec 26, 2021 •
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit a9c2b3d. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 44 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Dec 26, 2021 •
edited
Loading

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: a9c2b3d

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61c827fd6af1e000079a6817

@codecov
Copy link

codecov bot commented Dec 26, 2021 •
edited
Loading

Codecov Report

Merging #4347 (a9c2b3d) into main (9f58eab) will increase coverage by 1.47%.
The diff coverage is 95.72%.

@@            Coverage Diff             @@
##             main    #4347      +/-   ##
==========================================
+ Coverage   92.73%   94.21%   +1.47%     
==========================================
  Files         335      152     -183     
  Lines       11542     8118    -3424     
  Branches     3289     2599     -690     
==========================================
- Hits        10704     7648    -3056     
+ Misses        364      266      -98     
+ Partials      474      204     -270
Flag Coverage Δ
unittest 94.21% <95.72%> (+1.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/array-type.ts 97.18% <ø> (ø)
...kages/eslint-plugin/src/rules/no-empty-function.ts 80.00% <ø> (ø)
packages/eslint-plugin/src/rules/no-shadow.ts 76.33% <ø> (ø)
packages/eslint-plugin/src/rules/semi.ts 92.85% <ø> (ø)
...lugin/src/rules/padding-line-between-statements.ts 93.83% <75.00%> (+2.92%) ⬆️
...eslint-plugin/src/rules/consistent-type-imports.ts 94.26% <93.33%> (+0.78%) ⬆️
...eslint-plugin/src/rules/consistent-type-exports.ts 97.70% <94.44%> (+1.86%) ⬆️
...lugin/src/rules/consistent-indexed-object-style.ts 92.06% <100.00%> (+2.26%) ⬆️
...nt-plugin/src/rules/consistent-type-definitions.ts 97.29% <100.00%> (+8.10%) ⬆️
...ackages/eslint-plugin/src/rules/no-implied-eval.ts 97.05% <100.00%> (+2.94%) ⬆️
... and 245 more

bradzacher
bradzacher approved these changes Dec 27, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this

@bradzacher bradzacher merged commit 6edebcd into main Dec 27, 2021
@bradzacher bradzacher deleted the fix/2687-consistent-indexed-object-style branch December 27, 2021 06:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees

@armano2 armano2

Labels
bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[@typescript-eslint/consistent-indexed-object-style] Fails on circular references
2 participants
@armano2 @bradzacher